Skip to content

Fixed #35273 -- Fixed rendering AdminFileWidget's attributes.#17946

Merged
felixxm merged 2 commits intodjango:mainfrom
codingjoe:issues/35273
Mar 14, 2024
Merged

Fixed #35273 -- Fixed rendering AdminFileWidget's attributes.#17946
felixxm merged 2 commits intodjango:mainfrom
codingjoe:issues/35273

Conversation

@codingjoe
Copy link
Copy Markdown
Contributor

@codingjoe codingjoe commented Mar 6, 2024

Trac ticket number

ticket-35273

Branch description

Provide a concise overview of the issue or rationale behind the proposed changes.

Checklist

  • This PR targets the main branch.
  • The commit message is written in past tense, mentions the ticket number, and ends with a period.
  • I have checked the "Has patch" ticket flag in the Trac system.
  • I have added or updated relevant tests.
  • I have added or updated relevant docs, including release notes if applicable.
  • For UI changes, I have attached screenshots in both light and dark modes.

@codingjoe codingjoe force-pushed the issues/35273 branch 5 times, most recently from d351480 to b36d108 Compare March 8, 2024 19:49
@codingjoe codingjoe marked this pull request as ready for review March 8, 2024 19:49
@timgraham timgraham added the selenium Apply to have Selenium tests run on a PR label Mar 9, 2024
@timgraham timgraham changed the title Fixed #35273 -- Prevent ID-attribute duplication Fixed #35273 -- Prevented id attribute duplication of AdminFileWidget. Mar 9, 2024
Copy link
Copy Markdown
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codingjoe Thanks 👍 I left comments.

@felixxm
Copy link
Copy Markdown
Member

felixxm commented Mar 14, 2024

@codingjoe Do you have time to keep working on this? If not, I can reorganize commits.

@felixxm felixxm changed the title Fixed #35273 -- Prevented id attribute duplication of AdminFileWidget. Fixed #35273 -- Fixed rendering AdminFileWidget's attributes. Mar 14, 2024
@felixxm
Copy link
Copy Markdown
Member

felixxm commented Mar 14, 2024

@codingjoe Thanks 👍

@felixxm felixxm merged commit 3d7235c into django:main Mar 14, 2024
@codingjoe
Copy link
Copy Markdown
Contributor Author

@codingjoe Thanks 👍

Thanks @felixxm I appreciate the help <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

selenium Apply to have Selenium tests run on a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants