Repository navigation
Fixed #33319 -- Fixed crash when combining with the | operator querysets with aliases that conflict. - #15128
Conversation
|
Hello @omerfarukabaci! Thank you for your contribution 💪 As it's your first contribution be sure to check out the patch review checklist. If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket! If you have any design or process questions then you can ask in the Django forum. Welcome aboard ⛵️! |
fdb6288 to
0c42825
Compare
|
@charettes Thanks for your review, I hope I understand your point correctly. I have made the related changes, ready to review. |
2ee9e63 to
1337306
Compare
felixxm
left a comment
felixxm
left a comment
There was a problem hiding this comment.
@omerfarukabaci Thanks for updates 👍
2aa2dd1 to
5593597
Compare
|
You're welcome @felixxm! I have made the requested changes. 🚀 |
felixxm
changed the title
felixxm
left a comment
felixxm
left a comment
There was a problem hiding this comment.
@omerfarukabaci Thanks 👍 Welcome aboard ⛵
I pushed small edits and reorganized commits.
|
It's flattering to contribute to this great package, thank you guys a lot for your help! 🚀 |
|
@carltongibson Thanks 👍 I included your suggestions. |
AssertionErrorduringQuerySet'sORoperation is fixed.AssertionErroris documented in the code via comments.QuerySet'sORoperation is documented as it is not a commutative operation since the query of theqs1 | qs2andqs2 | qs1might differ, even though the results are expected to be same.