Repository navigation
Fixed #31420 -- Fixed crash when filtering subquery annotation against a SimpleLazyObject. - #12663
Merged
Merged
Conversation
charettes
approved these changes
Apr 4, 2020
charettes
left a comment
charettes
left a comment
Member
There was a problem hiding this comment.
As usual thanks for submitting a patch @hramezani 🙇
hramezani
force-pushed
the
ticket_31420
branch
5 times, most recently
from
April 5, 2020 01:05
5cb1471 to
41047ca
Compare
…t a SimpleLazyObject. Thanks Simon Charette for the solution and analysis.
felixxm
changed the title
felixxm
reviewed
Apr 6, 2020
felixxm
left a comment
felixxm
left a comment
Member
There was a problem hiding this comment.
@hramezani Thanks 👍 I added release notes.
Member
|
Docs failure is not related with this patch (see #12670). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ticket 31420.
Thanks, @charettes for the solution and @felixxm for the test case.