Skip to content

Fixed #31069, Refs #26431 -- Doc'd RegexPattern behavior change in passing optional named groups in Django 3.0.#12203

Merged
felixxm merged 1 commit intodjango:masterfrom
hramezani:ticket_31069
Dec 12, 2019
Merged

Fixed #31069, Refs #26431 -- Doc'd RegexPattern behavior change in passing optional named groups in Django 3.0.#12203
felixxm merged 1 commit intodjango:masterfrom
hramezani:ticket_31069

Conversation

@hramezani
Copy link
Copy Markdown
Member

@hramezani hramezani commented Dec 11, 2019

Copy link
Copy Markdown
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hramezani Thanks for this patch 👍 I left wording suggestions, please add also release notes under Backwards incompatible changes in 3.0 -> Miscellaneous.

@hramezani
Copy link
Copy Markdown
Member Author

hramezani commented Dec 11, 2019

@felixxm Thanks for your review and suggestion.
what do you think about the following release note for Backwards incompatible changes:

*‌ The keyword arguments with ``None`` values in matched URL pattern are no
  longer get passed to view, also for not provided named parts.

@felixxm
Copy link
Copy Markdown
Member

felixxm commented Dec 11, 2019

We can take a releases/3.0.1.txt as a pattern 🤔 , e.g.:

* ``RegexPattern``, used by :func:`~django.urls.re_path`, no longer return a
  keyword argument with ``None`` value to be passed to the view for the
  optional named group that is missing.

@felixxm felixxm self-assigned this Dec 11, 2019
@hramezani
Copy link
Copy Markdown
Member Author

  • RegexPattern, used by :func:~django.urls.re_path, no longer return a
    keyword argument with None value to be passed to the view for the
    optional named group that is missing.

Thanks, I just replaced no longer return with no longer returns.

@felixxm felixxm changed the title Fixed #31069 -- Documented change in behavior for optional re matches. Fixed #31069, Refs #26431 -- Doc'd RegexPattern behavior change in passing optional named groups in Django 3.0. Dec 12, 2019
@felixxm
Copy link
Copy Markdown
Member

felixxm commented Dec 12, 2019

@hramezani Thanks 👍

@felixxm felixxm merged commit 9736137 into django:master Dec 12, 2019
collinanderson added a commit to collinanderson/django that referenced this pull request Sep 17, 2024
RosanaRufer added a commit to RosanaRufer/django that referenced this pull request Sep 18, 2024
RosanaRufer added a commit to RosanaRufer/django that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants