This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[google_sign_in] Plugin for web #101
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
ditman
force-pushed
the
federated_google_sign_in_web
branch
from
b9a32b0 to
00d2baf
Compare
ditman
force-pushed
the
federated_google_sign_in_native
branch
from
0aae2ab to
6c32b97
Compare
ditman
force-pushed
the
federated_google_sign_in_web
branch
from
00d2baf to
e9b0de0
Compare
Owner
Author
|
(Rebased with latest federated_google_sign_in_native) |
ditman
force-pushed
the
federated_google_sign_in_native
branch
from
6c32b97 to
0f8aa13
Compare
ditman
force-pushed
the
federated_google_sign_in_web
branch
from
55dcc85 to
65b5f9b
Compare
Owner
Author
|
(Rebased with latest federated_google_sign_in_native) |
ditman
force-pushed
the
federated_google_sign_in_native
branch
from
ba2b8ae to
7d626a8
Compare
- Adds support in the plugin - Adds a v2 embedding to the example app - Fixes a broken remote example in the example app - Increments the Flutter SDK dependency - Increments the version - Adds e2e tests for some simple use cases of the plugin
ditman
force-pushed
the
federated_google_sign_in_web
branch
from
65b5f9b to
8c2a221
Compare
- Add a lint to url_launcher and url_launcher_platform_interface to prevent undocumented public members. - Add some unit tests.
Previously all navigation decisions needed to be made synchronously in Dart. The platform layers are already waiting for the MethodChannel callback, so just changed the return type to be `FutureOr<NavigationDecision>'. This is a change to the method signature of `WebViewPlatformCallbacksHandler#onNavigationRequest`, but that interface appears to only be meant to be implemented internally to the plugin.
…lutter#2266) * Port google_sign_in.dart to use the federated Platform Interface, instead of MethodChannels. * Ignore google_sign_in_platform_interface on all-plugins-app call. * Refactor endlessly growing --exclude param value into a string that gets generated for a list of plugin names.
ditman
force-pushed
the
federated_google_sign_in_web
branch
from
2647393 to
8c55b95
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a web implementation of the google_sign_in plugin, via JS interop with the gapi object.
Related Issues
flutter/flutter#43774
Missing stuff
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?