[release/2.8 backport] Enable Go build tags#4009
Merged
milosgajdos merged 3 commits intodistribution:release/2.8from Aug 22, 2023
Merged
[release/2.8 backport] Enable Go build tags#4009milosgajdos merged 3 commits intodistribution:release/2.8from
milosgajdos merged 3 commits intodistribution:release/2.8from
Conversation
This enables go build tags so the GCS and OSS driver support is available in the binary distributed via the image build by Dockerfile. This led to quite a few fixes in the GCS and OSS packages raised as warning by golang-ci linter. Signed-off-by: Milos Gajdos <[email protected]> (cherry picked from commit 6b388b1) Signed-off-by: Sebastiaan van Stijn <[email protected]>
This was added for the other drivers in 6b388b1, but it missed the s3 storage driver. Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit 5b3be39) Signed-off-by: Sebastiaan van Stijn <[email protected]>
It would appear we were missing the Go build tags on 2.8.X branch so the images would not have the necessary support for some storage drivers causing breakages to end users trying to use them. This commit fixes both the build and linting issues. Signed-off-by: Milos Gajdos <[email protected]>
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## release/2.8 #4009 +/- ##
============================================
Coverage 58.87% 58.87%
============================================
Files 102 102
Lines 7120 7120
============================================
Hits 4192 4192
Misses 2284 2284
Partials 644 644 ☔ View full report in Codecov by Sentry. |
Member
|
Do you wanna close this one @thaJeztah as it's a dupe of #3927 which was open earlier. |
Member
|
@thaJeztah can you mark this ready for review? |
milosgajdos
approved these changes
Aug 22, 2023
nrdufour
added a commit
to nrdufour/home-ops
that referenced
this pull request
Oct 3, 2023
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [registry](https://github.com/distribution/distribution) | patch | `2.8.2` -> `2.8.3` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the logs for more information. --- ### Release Notes <details> <summary>distribution/distribution (registry)</summary> ### [`v2.8.3`](https://github.com/distribution/distribution/releases/tag/v2.8.3) [Compare Source](distribution/distribution@v2.8.2...v2.8.3) ##### What's Changed - Pass `BUILDTAGS` argument to `go build` by [@​marcusirgens](https://github.com/marcusirgens) in distribution/distribution#3926 - Enable Go build tags by [@​thaJeztah](https://github.com/thaJeztah) in distribution/distribution#4009 - `reference`: replace deprecated function `SplitHostname` by [@​thaJeztah](https://github.com/thaJeztah) in distribution/distribution#4032 - Dont parse errors as JSON unless Content-Type is set to JSON by [@​thaJeztah](https://github.com/thaJeztah) in distribution/distribution#4054 - update to go 1.20.8 by [@​thaJeztah](https://github.com/thaJeztah) in distribution/distribution#4056 - Set `Content-Type` header in registry client `ReadFrom` by [@​thaJeztah](https://github.com/thaJeztah) in distribution/distribution#4053 - deprecate reference package, migrate to github.com/distribution/reference by [@​thaJeztah](https://github.com/thaJeztah) in distribution/distribution#4063 - `digestset`: deprecate package in favor of `go-digest/digestset` by [@​thaJeztah](https://github.com/thaJeztah) in distribution/distribution#4064 - Do not close HTTP request body in HTTP handler by [@​milosgajdos](https://github.com/milosgajdos) in distribution/distribution#4068 - Add v2.8.3 release notes by [@​milosgajdos](https://github.com/milosgajdos) in distribution/distribution#4088 ##### New Contributors - [@​marcusirgens](https://github.com/marcusirgens) made their first contribution in distribution/distribution#3926 **Full Changelog**: distribution/distribution@v2.8.2...v2.8.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zLjIiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zLjIiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> Reviewed-on: https://git.home/nrdufour/home-ops/pulls/127 Co-authored-by: Renovate <[email protected]> Co-committed-by: Renovate <[email protected]>
Mengkzhaoyun
pushed a commit
to open-beagle/distribution
that referenced
this pull request
Dec 14, 2023
registry 2.8.3 Welcome to the v2.8.3 release of registry! Welcome to the 2.8.3 release of registry! The 2.8.3 registry release fixes a few bugs and makes a few dependency updates. The Go runtime has been bumped to 1.20.8. See the changelog below for full list of changes. * Do not close HTTP request body in HTTP handler ([distribution#4068](distribution#4068)) * Set Content-Type header in registry client ReadFrom ([distribution#4053](distribution#4053)) * Do not parse errors as JSON unless Content-Type is set to JSON ([distribution#4054](distribution#4054)) * Enable Go build tags ([distribution#4009](distribution#4009)) * replace deprecated function SplitHostname ([distribution#4032](distribution#4032)) * update to go1.20.8 ([distribution#4056](distribution#4056)) * deprecate digestset package in favor of go-digest/digestset ([distribution#4064](distribution#4064)) * deprecate reference package, migrate to github.com/distribution/reference ([distribution#4063](distribution#4063)) Previous release can be found at [v2.8.2](https://github.com/distribution/distribution/releases/tag/v2.8.2) Please try out the release binaries and report any issues at https://github.com/distribution/distribution/issues. * Milos Gajdos * Sebastiaan van Stijn * Milos Gajdos * James Hewitt * Ben Manuel * Marcus Pettersen Irgens * zounengren <details><summary>30 commits</summary> <p> * Add v2.8.3 release notes ([distribution#4088](distribution#4088)) * [`a4fa6992`](distribution@a4fa699) Add v2.8.3 release notes * [release/2.8] Do not close HTTP request body in HTTP handler ([distribution#4068](distribution#4068)) * [`5e6b1b5c`](distribution@5e6b1b5) Do not close HTTP request body in HTTP handler * [release/2.8] digestset: deprecate package in favor of go-digest/digestset ([distribution#4064](distribution#4064)) * [`29b00e8b`](distribution@29b00e8) digestset: deprecate package in favor of go-digest/digestset * [`d1ab2430`](distribution@d1ab243) [release/2.8] vendor: github.com/opencontainers/go-digest v1.0.0 * [release/2.8] deprecate reference package, migrate to github.com/distribution/reference ([distribution#4063](distribution#4063)) * [`3dda0677`](distribution@3dda067) deprecate reference package, migrate to github.com/distribution/reference * [release/2.8 backport] Set Content-Type header in registry client ReadFrom ([distribution#4053](distribution#4053)) * [`cb121c3f`](distribution@cb121c3) Set Content-Type header in registry client ReadFrom * [release/2.8] update to go1.20.8 ([distribution#4056](distribution#4056)) * [`3c6f7788`](distribution@3c6f778) update to go1.20.8 * [`31f5cd48`](distribution@31f5cd4) Handle rand deprecations in go 1.20 * [`29b8ba0b`](distribution@29b8ba0) Update to go 1.20 * [`3316b198`](distribution@3316b19) Update to golang 1.19.10 * [`444d053e`](distribution@444d053) update golangci-lint to v1.52 * [`b800af44`](distribution@b800af4) ignore SA1019: ac.(*accessController).rootCerts.Subjects has been deprecated * [`0a98a00d`](distribution@0a98a00) Ignore SA1019: SplitHostname is deprecated. * [release/2.8 backport] Dont parse errors as JSON unless Content-Type is set to JSON ([distribution#4054](distribution#4054)) * [`2ec0471b`](distribution@2ec0471) Dont parse errors as JSON unless Content-Type is set to JSON * [release/2.8 backport] reference: replace deprecated function SplitHostname ([distribution#4032](distribution#4032)) * [`b57133cc`](distribution@b57133c) referene: fix formatting of "deprecated" comment. * [`2c4bf1a6`](distribution@2c4bf1a) replace deprecated function * [release/2.8 backport] Enable Go build tags ([distribution#4009](distribution#4009)) * [`110cb753`](distribution@110cb75) Enable build tags in 2.8 * [`2d62a402`](distribution@2d62a40) s3: add interface assertion * [`2548973b`](distribution@2548973) Enable Go build tags * Pass `BUILDTAGS` argument to `go build` ([distribution#3926](distribution#3926)) * [`ab7178cc`](distribution@ab7178c) Pass BUILDTAGS argument to go build </p> </details> * **github.com/distribution/reference** 49c28499d219 **_new_** * **github.com/opencontainers/go-digest** a6d0ee40d420 -> ea51bea511f7 Previous release can be found at [v2.8.2](https://github.com/distribution/distribution/releases/tag/v2.8.2)
quotengrote
pushed a commit
to quotengrote/ansible
that referenced
this pull request
Jan 26, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [registry](https://github.com/distribution/distribution) | patch | `2.8.2` -> `2.8.3` | --- > ⚠ **Warning** > > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>distribution/distribution (registry)</summary> ### [`v2.8.3`](https://github.com/distribution/distribution/releases/tag/v2.8.3) [Compare Source](distribution/distribution@v2.8.2...v2.8.3) #### What's Changed - Pass `BUILDTAGS` argument to `go build` by [@​marcusirgens](https://github.com/marcusirgens) in distribution/distribution#3926 - Enable Go build tags by [@​thaJeztah](https://github.com/thaJeztah) in distribution/distribution#4009 - `reference`: replace deprecated function `SplitHostname` by [@​thaJeztah](https://github.com/thaJeztah) in distribution/distribution#4032 - Dont parse errors as JSON unless Content-Type is set to JSON by [@​thaJeztah](https://github.com/thaJeztah) in distribution/distribution#4054 - update to go 1.20.8 by [@​thaJeztah](https://github.com/thaJeztah) in distribution/distribution#4056 - Set `Content-Type` header in registry client `ReadFrom` by [@​thaJeztah](https://github.com/thaJeztah) in distribution/distribution#4053 - deprecate reference package, migrate to github.com/distribution/reference by [@​thaJeztah](https://github.com/thaJeztah) in distribution/distribution#4063 - `digestset`: deprecate package in favor of `go-digest/digestset` by [@​thaJeztah](https://github.com/thaJeztah) in distribution/distribution#4064 - Do not close HTTP request body in HTTP handler by [@​milosgajdos](https://github.com/milosgajdos) in distribution/distribution#4068 - Add v2.8.3 release notes by [@​milosgajdos](https://github.com/milosgajdos) in distribution/distribution#4088 #### New Contributors - [@​marcusirgens](https://github.com/marcusirgens) made their first contribution in distribution/distribution#3926 **Full Changelog**: distribution/distribution@v2.8.2...v2.8.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNTIuMSIsInVwZGF0ZWRJblZlciI6IjM3LjE1Mi4xIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=--> Reviewed-on: https://git.mgrote.net/mg/homeserver/pulls/667 Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backports:
And rebases #3927 to get the remaining changes