Skip to content

update to go1.19.9#3905

Merged
milosgajdos merged 1 commit intodistribution:mainfrom
thaJeztah:bump_go_1.19.9
May 9, 2023
Merged

update to go1.19.9#3905
milosgajdos merged 1 commit intodistribution:mainfrom
thaJeztah:bump_go_1.19.9

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented May 9, 2023 •
edited
Loading

Added back minor versions in these, so that we have a somewhat more
reproducible state in the repository when tagging releases.

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2023 •
edited
Loading

Codecov Report

Patch coverage: 75.00% and project coverage change: -0.01 ⚠️

Comparison is base (c9b844e) 56.76% compared to head (e19a207) 56.76%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3905      +/-   ##
==========================================
- Coverage   56.76%   56.76%   -0.01%     
==========================================
  Files         106      106              
  Lines       10681    10680       -1     
==========================================
- Hits         6063     6062       -1     
  Misses       3944     3944              
  Partials      674      674
Impacted Files Coverage Δ
registry/storage/schema2manifesthandler.go 62.35% <0.00%> (ø)
registry/handlers/manifests.go 54.17% <66.66%> (ø)
registry/registry.go 47.03% <80.00%> (-0.18%) ⬇️
registry/storage/signedmanifesthandler.go 42.52% <83.33%> (ø)
registry/storage/manifeststore.go 76.74% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@thaJeztah
Copy link
Member Author

thaJeztah commented May 9, 2023

We'll probably need an updated golangci-lint;

 > [stage-2 1/1] RUN --mount=type=bind,target=.     --mount=type=cache,target=/root/.cache     --mount=from=golangci-lint,source=/usr/bin/golangci-lint,target=/usr/bin/golangci-lint       golangci-lint run:
#17 10.70 panic: load embedded ruleguard rules: rules/rules.go:13: can't load fmt
#17 10.70 
#17 10.70 goroutine 1 [running]:
#17 10.70 github.com/go-critic/go-critic/checkers.init.22()
#17 10.70 	github.com/go-critic/[email protected]/checkers/embedded_rules.go:46 +0x4b4

@thaJeztah
Copy link
Member Author

thaJeztah commented May 9, 2023 •
edited
Loading

@thaJeztah
Copy link
Member Author

thaJeztah commented May 9, 2023

(I'll rebase this one once the other PR is merged to remove the golangci-lint update commits)

@milosgajdos milosgajdos requested a review from corhere May 9, 2023 14:41
@thaJeztah thaJeztah mentioned this pull request May 9, 2023
Merged
@thaJeztah
update to go1.19.9
322eb4e 
Added back minor versions in these, so that we have a somewhat more
reproducible state in the repository when tagging releases.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah
Copy link
Member Author

thaJeztah commented May 9, 2023

@milosgajdos @corhere rebased; this should be ready for review now

@milosgajdos milosgajdos merged commit ada0064 into distribution:main May 9, 2023
@thaJeztah thaJeztah deleted the bump_go_1.19.9 branch May 9, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corhere corhere corhere approved these changes

@milosgajdos milosgajdos milosgajdos approved these changes

@deleteriousEffect deleteriousEffect Awaiting requested review from deleteriousEffect

@squizzi squizzi Awaiting requested review from squizzi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thaJeztah @codecov-commenter @corhere @milosgajdos