[release/2.8] Fix panic in inmemory driver#3815
Merged
milosgajdos merged 1 commit intodistribution:release/2.8from Apr 17, 2023
wy65701436:release/2.8-cp-3615
Merged
[release/2.8] Fix panic in inmemory driver#3815milosgajdos merged 1 commit intodistribution:release/2.8from wy65701436:release/2.8-cp-3615
milosgajdos merged 1 commit intodistribution:release/2.8from
wy65701436:release/2.8-cp-3615
Conversation
Signed-off-by: Shengjing Zhu <[email protected]>
thaJeztah
changed the title
Member
|
Hm, right so looks like this fails because it's installing "github.com/vbatts/git-validation" "latest", which installs a version of cd /tmp && go get -u github.com/vbatts/git-validation
....
# golang.org/x/sys/unix
Error: /home/runner/work/distribution/distribution/src/golang.org/x/sys/unix/syscall.go:83:16: undefined: unsafe.Slice
Error: /home/runner/work/distribution/distribution/src/golang.org/x/sys/unix/syscall_linux.go:1018:20: undefined: unsafe.Slice
Error: /home/runner/work/distribution/distribution/src/golang.org/x/sys/unix/syscall_linux.go:2297:9: undefined: unsafe.Slice
Error: /home/runner/work/distribution/distribution/src/golang.org/x/sys/unix/syscall_unix.go:118:7: undefined: unsafe.Slice
Error: /home/runner/work/distribution/distribution/src/golang.org/x/sys/unix/sysvshm_unix.go:33:7: undefined: unsafe.Slice
Error: Process completed with exit code 2. |
thaJeztah
approved these changes
Apr 17, 2023
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
(failure is not related, as described above)
milosgajdos
approved these changes
Apr 17, 2023
Member
milosgajdos
left a comment
milosgajdos
left a comment
There was a problem hiding this comment.
LGTM. This attempts to rip out https://github.com/distribution/distribution/pull/3812/files#r1038982612 from #3812 and we are aware of what the issue is hence approving and merging so we can get #3812 merged in.
nrdufour
added a commit
to nrdufour/home-ops
that referenced
this pull request
Jul 29, 2023
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [registry](https://github.com/distribution/distribution) | patch | `2.8.1` -> `2.8.2` | --- ### Release Notes <details> <summary>distribution/distribution (registry)</summary> ### [`v2.8.2`](https://github.com/distribution/distribution/releases/tag/v2.8.2) [Compare Source](distribution/distribution@v2.8.1...v2.8.2) ##### What's Changed - Revert registry/client: set `Accept: identity` header when getting layers by [@​ndeloof](https://github.com/ndeloof) in distribution/distribution#3783 - Parse `http` forbidden as denied by [@​vvoland](https://github.com/vvoland) in distribution/distribution#3914 - Fix [CVE-2022-28391](https://www.cve.org/CVERecord?id=CVE-2022-28391) by bumping alpine from 3.14 to 3.16 by [@​thaJeztah](https://github.com/thaJeztah) ([#​3650](distribution/distribution#3650)) - Fix [CVE-2023-2253](https://www.cve.org/CVERecord?id=CVE-2023-2253) runaway allocation on /v2/\_catalog by [@​josegomezr](https://github.com/josegomezr) [`521ea3d9`](distribution/distribution@521ea3d) - Fix panic in inmemory driver by [@​wy65701436](https://github.com/wy65701436) in distribution/distribution#3815 - bump up golang version (alternative) by [@​thaJeztah](https://github.com/thaJeztah) in distribution/distribution#3903 - Dockerfile: update xx to v1.2.1 by [@​thaJeztah](https://github.com/thaJeztah) in distribution/distribution#3907 - update to go1.19.9 by [@​thaJeztah](https://github.com/thaJeztah) in distribution/distribution#3908 - Add code to handle pagination of parts. Fixes max layer size of 10GB bug by [@​DavidSpek](https://github.com/DavidSpek) in distribution/distribution#3893 - Dockerfile: fix filenames of artifacts by [@​thaJeztah](https://github.com/thaJeztah) in distribution/distribution#3911 **Full Changelog**: distribution/distribution@v2.8.1...v2.8.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4yMy4yIiwidXBkYXRlZEluVmVyIjoiMzYuMjMuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Reviewed-on: https://git.home/nrdufour/home-ops/pulls/20 Co-authored-by: Renovate <[email protected]> Co-committed-by: Renovate <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.