reference: replace deprecated function SplitHostname#3776
Merged
milosgajdos merged 2 commits intodistribution:mainfrom Nov 8, 2022
Merged
reference: replace deprecated function SplitHostname#3776milosgajdos merged 2 commits intodistribution:mainfrom
milosgajdos merged 2 commits intodistribution:mainfrom
Conversation
Signed-off-by: Zou Nengren <[email protected]> Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
ref_replace_deprecated
branch
from
2da7af3 to
79d1901
Compare
Go requires "deprecated" comments to have an empty line before them, and to not be all-caps. This updates to the comment so that it's correctly picked up as deprecated. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Codecov ReportBase: 57.06% // Head: 56.87% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #3776 +/- ##
==========================================
- Coverage 57.06% 56.87% -0.19%
==========================================
Files 105 105
Lines 10806 10804 -2
==========================================
- Hits 6166 6145 -21
- Misses 3952 3969 +17
- Partials 688 690 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
milosgajdos
approved these changes
Nov 6, 2022
Member
Author
|
@corhere PTAL 🤗 |
corhere
approved these changes
Nov 8, 2022
Member
Author
|
@milosgajdos looks like @corhere is on the maintainers list, but does not have the right permissions; Line 9 in e9a25da Can we fix that? ❤️ |
Member
|
Invite sent; @corhere you should get an email that invites you to this org/repo as a maintainer. Once you accept we good! |
Member
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-porting the patch from containerd/containerd@694a007 (containerd/containerd#5922)