Revert "registry/client: set Accept: identity header when getting layers#3754
Merged
milosgajdos merged 1 commit intodistribution:mainfrom Nov 3, 2022
Merged
Revert "registry/client: set Accept: identity header when getting layers#3754milosgajdos merged 1 commit intodistribution:mainfrom
milosgajdos merged 1 commit intodistribution:mainfrom
Conversation
…ers" This reverts commit 16f086a. Signed-off-by: Nicolas De Loof <[email protected]>
ndeloof
force-pushed
the
accept-encoding
branch
from
856aca8 to
9c04d0b
Compare
Member
|
FWIW, we should consider this a bug; the original reason for adding this was effectively working around a mis-configured registry, and as a result we now have a client that is (partially) disfunctional. Perhaps worth backporting (as there's no release for v3 yet, so most consumers will still be using the v2 branch). As a follow-up we should also consider implementing something like containerd/containerd#7563, but that's a larger change (and more a "feature"). |
milosgajdos
approved these changes
Nov 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This revisits fix provided regarding moby/moby#25122
According to https://www.rfc-editor.org/rfc/rfc9110.html#name-content-encoding
So, an image layer, served with media type
application/vnd.oci.image.layer.v1.tar+gzipshould not get any additionalContent-Encodingheader set until http server is misconfigured.Using a preventive
Accept-Encoding: identityallows to avoid such a misconfiguration to have consequences on image transfert, but on the other hand prevents adoption of any other transport optimization, while the defaultnet/httpgolang transport transparently managesgzipand can at least compress json manifests.This would also make it possible to publish images with uncompressed layers referenced in manifests, and get those served with gzip or a more efficient compression (zstd, or any future algorithm) using encoding negotiation between client and registry.