Skip to content

Dockerfile: pass BUILDTAGS to go build#3703

Closed
kaovilai wants to merge 1 commit intodistribution:mainfrom
kaovilai:docker_buildtags
Closed

Dockerfile: pass BUILDTAGS to go build#3703
kaovilai wants to merge 1 commit intodistribution:mainfrom
kaovilai:docker_buildtags

Conversation

@kaovilai
Copy link
Contributor

@kaovilai kaovilai commented Jul 29, 2022

No description provided.

@kaovilai kaovilai changed the title Dockerfile: pass buildtags to go build Dockerfile: pass BUILDTAGS to go build Jul 29, 2022
@kaovilai kaovilai force-pushed the docker_buildtags branch 2 times, most recently from 2b27085 to e54c298 Compare July 29, 2022 16:22
@milosgajdos milosgajdos requested a review from thaJeztah July 29, 2022 16:33
@thaJeztah
Copy link
Member

thaJeztah commented Jul 29, 2022

Looks like there's an issue; perhaps quoting is incorrect? (haven't checked);

#23 0.636 malformed import path "-trimpath": leading dash
#23 0.636 malformed import path "-ldflags": leading dash
#23 0.636 malformed import path "-X github.com/distribution/distribution/v3/version.Version=2.7.0-2007-ge1a30f7d -X github.com/distribution/distribution/v3/version.Revision=e1a30f7d2c609a9ad2f73b3566dab69cf5c89298 -X github.com/distribution/distribution/v3/version.Package=github.com/distribution/distribution/v3 -s -w": leading dash
#23 0.636 malformed import path "-o": leading dash

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2022 •
edited
Loading

Codecov Report

Merging #3703 (ce70cb7) into main (4bf3547) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3703      +/-   ##
==========================================
+ Coverage   57.38%   57.39%   +0.01%     
==========================================
  Files         105      105              
  Lines       10832    10835       +3     
==========================================
+ Hits         6216     6219       +3     
  Misses       3932     3932              
  Partials      684      684
Impacted Files Coverage Δ
registry/api/v2/routes.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bf3547...ce70cb7. Read the comment docs.

crazy-max
crazy-max suggested changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per @thaJeztah comment, missing quotes.

@kaovilai
Copy link
Contributor Author

kaovilai commented Jul 29, 2022

squahsing into 1 commit just in case

@kaovilai
Dockerfile: pass buildtags to go build
ce70cb7 
Signed-off-by: Tiger Kaovilai <[email protected]>

Have I told you how much I love quotes?

Signed-off-by: Tiger Kaovilai <[email protected]>
@kaovilai kaovilai requested a review from milosgajdos July 29, 2022 17:02
@kaovilai
Copy link
Contributor Author

kaovilai commented Jul 29, 2022

blocked by #3702. So cherry pick into there maybe?

@milosgajdos
Copy link
Member

milosgajdos commented Jul 29, 2022

There is a whole chain of PRs 😬 I'd love someone with proper knowledge of GCS to review #3702 but I dont think we have anyone in @distribution/distribution-maintainers whos got that knowledge 🤔

@kaovilai kaovilai mentioned this pull request Jul 29, 2022
Closed
@kaovilai
Copy link
Contributor Author

kaovilai commented Jul 29, 2022

From digging.. it was after 87f93ed#diff-dd2c0eb6ea5cfc6c4bd4eac30934e2d5746747af48fef6da689e85b752f39557L25 that tags were lost

kaovilai referenced this pull request Jul 29, 2022
@crazy-max
Dockerfile: switch to xx
87f93ed 
Signed-off-by: CrazyMax <[email protected]>
@flavianmissi
Copy link
Contributor

flavianmissi commented May 23, 2023

FTR there's a new PR up to fix the GCS driver (the previous one was closed): #3929

@kaovilai
Copy link
Contributor Author

kaovilai commented May 23, 2023

blocked by #3929

@milosgajdos
Copy link
Member

milosgajdos commented May 23, 2023

There is also #3926

@kaovilai
Copy link
Contributor Author

kaovilai commented May 23, 2023

There is a whole chain of PRs 😬 I'd love someone with proper knowledge of GCS to review #3702 but I dont think we have anyone in @distribution/distribution-maintainers whos got that knowledge 🤔

What's the plan with v3 if there is no GCS maintainer? add new maintainer? kill off GCS driver?

@davidspek
Copy link
Collaborator

davidspek commented Aug 15, 2023

@kaovilai Could you rebase this PR since #3929 has now been merged.

@milosgajdos
Copy link
Member

milosgajdos commented Aug 15, 2023

Closing, addressed in #3950

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thaJeztah thaJeztah Awaiting requested review from thaJeztah

@milosgajdos milosgajdos Awaiting requested review from milosgajdos

1 more reviewer

@crazy-max crazy-max crazy-max requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@kaovilai @thaJeztah @codecov-commenter @milosgajdos @flavianmissi @davidspek @crazy-max