update to go 1.18 (continue testing against 1.17)#3643
Merged
milosgajdos merged 2 commits intodistribution:mainfrom May 5, 2022
Merged
update to go 1.18 (continue testing against 1.17)#3643milosgajdos merged 2 commits intodistribution:mainfrom
milosgajdos merged 2 commits intodistribution:mainfrom
Conversation
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #3643 +/- ##
==========================================
- Coverage 56.62% 56.58% -0.04%
==========================================
Files 103 103
Lines 7520 7520
==========================================
- Hits 4258 4255 -3
- Misses 2593 2596 +3
Partials 669 669
Continue to review full report at Codecov.
|
Member
Author
|
We'll need to update the list of "required" checks again after this (as their name is based on the go version) |
Member
Author
|
Argh... this one ..... (no, it's not a breaking change 😂) |
Member
|
we seem to be missing |
Go 1.16 reached end of life, so update to the current version of Go, but also run CI on the previous version (which is still supported). We should probably also decide wether or not we want the Dockerfiles to pin to a specific minor version; this makes the releases more deterministic. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
commented
May 5, 2022
| WORKDIR /src | ||
|
|
||
| FROM base | ||
| ENV GOFLAGS="-buildvcs=false" |
Member
Author
There was a problem hiding this comment.
That should probably do the trick as well; didn't want to add git as a dependency for linting if it's not needed.
Member
Author
|
Whoop! All green now! |
milosgajdos
approved these changes
May 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go 1.16 reached end of life, so update to the current version of Go, but also
run CI on the previous version (which is still supported).
We should probably also decide wether or not we want the Dockerfiles to pin to
a specific minor version; this makes the releases more deterministic.