dockerfile: check statically linked#3639
Closed
crazy-max wants to merge 1 commit intodistribution:mainfrom
Closed
Conversation
Signed-off-by: CrazyMax <[email protected]>
thaJeztah
reviewed
May 3, 2022
| --files="LICENSE" \ | ||
| --files="README.md" | ||
| --files="README.md" \ | ||
| && xx-verify --static /usr/local/bin/registry |
Member
There was a problem hiding this comment.
Out of curiosity; Do we need both xx and goreleaser-xx ? Where do they overlap, and where are the gaps between the two?
Contributor
Author
There was a problem hiding this comment.
Yes there is no static check in goreleaser-xx atm but I could add it or we could switch to xx but would need a dedicated stage to create tarballs which seems fine if we want to.
Member
There was a problem hiding this comment.
Yeah, mostly it feels like there's a large overlap between the two, so it possible, it would be nice to "pick one" (I'm impartial to "which one", as long as (if possible) it's "one" 😅
milosgajdos
approved these changes
May 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes sure binary is statically linked and also adds
-trimpathbuild flag.cc @milosgajdos
Signed-off-by: CrazyMax [email protected]