Update vendored azure-sdk-for-go#2027
Update vendored azure-sdk-for-go#2027dmcgowan merged 1 commit intodistribution:masterfrom ahmetb:pr-azure-memleak2
Conversation
Current coverage is 50.89% (diff: 0.00%)@@ master #2027 diff @@
==========================================
Files 126 125 -1
Lines 11263 11137 -126
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 6927 5668 -1259
- Misses 3449 4726 +1277
+ Partials 887 743 -144
|
Godeps/Godeps.json
Outdated
| "ImportPath": "github.com/Azure/azure-sdk-for-go/storage", | ||
| "Comment": "v1.2-334-g95361a2", | ||
| "Rev": "95361a2573b1fa92a00c5fc2707a80308483c6f9" | ||
| "Comment": "v6.0.0-beta", |
There was a problem hiding this comment.
I don't like using a package marked as beta in a production system.
Is there something between v1.2 and v6 that is more stable?
There was a problem hiding this comment.
@RichardScothern It's all stable, don't mind the name. 😸 I'm not sure why we still keep adding -beta.
|
LGTM |
|
More love for this PR? |
|
Actually, let's not merge it yet, I discovered some bugs in our SDK that I need to first patch in the azure-sdk-for-go repo. |
Updating to a recent version of Azure Storage SDK to be able to patch some memory leaks through configurable HTTP client changes which were made possible by recent patches to it. Signed-off-by: Ahmet Alp Balkan <[email protected]>
RichardScothern
changed the title
|
@RichardScothern ready to go now! I updated the vendored bits to include this commit which was giving a nil dereference error on some improper |
|
LGTM, update name now? |
ahmetb
changed the title
|
@dmcgowan updated. |
|
2 LGTMs, so merge maybe? 😸 |
Ref: distribution#2027 Signed-off-by: Ahmet Alp Balkan <[email protected]>
Ref: distribution#2027 Signed-off-by: Ahmet Alp Balkan <[email protected]>
5 participants
Updating to a recent version of Azure Storage SDK to be
able to patch some memory leaks through configurable HTTP client
change added to the registry recently.