Skip to content

Add failing test case for reference.SplitHostname#1777

Closed
ejholmes wants to merge 1 commit intodistribution:masterfrom
ejholmes:split-hostname
Closed

Add failing test case for reference.SplitHostname#1777
ejholmes wants to merge 1 commit intodistribution:masterfrom
ejholmes:split-hostname

Conversation

@ejholmes
Copy link

@ejholmes ejholmes commented Jun 9, 2016

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "split-hostname" [email protected]:ejholmes/distribution.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

@dmcgowan
Copy link
Collaborator

dmcgowan commented Jun 9, 2016

I commented on the other discussion but will repeat this here. Currently the parser leaves such ambiguity up to the caller to resolve. We should provide better documentation and tools for handling this ambiguity. For the Docker use case, this specified case always gets canonicalized as a public image reference.

This is a good case to add since it is both a valid hostname and name component.

@stevvooe
Copy link
Collaborator

stevvooe commented Jun 9, 2016

@ejholmes Thanks for filing this. We are working towards incorporating a correct change here.

@codecov-io
Copy link

Current coverage is 54.72%

Merging #1777 into master will decrease coverage by 6.90%

@@             master      #1777   diff @@
==========================================
  Files           120        120          
  Lines         10455      10455          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits           6443       5721   -722   
- Misses         3417       4231   +814   
+ Partials        595        503    -92   

Sunburst

Powered by Codecov. Last updated by 75882f0...9e4f64c

@dmcgowan
Copy link
Collaborator

Closing in favor of #2132. Using the normalized name parser should give a result more consistent with what is used within the docker engine.

@dmcgowan dmcgowan closed this Jan 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants