Add failing test case for reference.SplitHostname#1777
Add failing test case for reference.SplitHostname#1777ejholmes wants to merge 1 commit intodistribution:masterfrom
Conversation
|
Please sign your commits following these rules: $ git clone -b "split-hostname" [email protected]:ejholmes/distribution.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmmending updates the existing PR. You DO NOT need to open a new one. |
Signed-off-by: Eric J. Holmes <[email protected]>
|
I commented on the other discussion but will repeat this here. Currently the parser leaves such ambiguity up to the caller to resolve. We should provide better documentation and tools for handling this ambiguity. For the Docker use case, this specified case always gets canonicalized as a public image reference. This is a good case to add since it is both a valid hostname and name component. |
|
@ejholmes Thanks for filing this. We are working towards incorporating a correct change here. |
Current coverage is 54.72%@@ master #1777 diff @@
==========================================
Files 120 120
Lines 10455 10455
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 6443 5721 -722
- Misses 3417 4231 +814
+ Partials 595 503 -92
|
|
Closing in favor of #2132. Using the normalized name parser should give a result more consistent with what is used within the docker engine. |
See https://github.com/docker/distribution/pull/963/files/b07d759241defb2f345e95ed04bfdeb8ac010ab2#r66186285 for background context.
This adds a failing test case for the issue mentioned there.