Skip to content

Avoid empty Accept headers in client requests#1380

Merged
stevvooe merged 1 commit intodistribution:masterfrom
aaronlehmann:avoid-empty-accept-header
Jan 20, 2016
Merged

Avoid empty Accept headers in client requests#1380
stevvooe merged 1 commit intodistribution:masterfrom
aaronlehmann:avoid-empty-accept-header

Conversation

@aaronlehmann
Copy link
Copy Markdown

One of the keys in the manifest media type map is an empty string. This
should not be sent as an Accept header.

One of the keys in the manifest media type map is an empty string. This
should not be sent as an Accept header.

Signed-off-by: Aaron Lehmann <[email protected]>
@BrianBland
Copy link
Copy Markdown
Contributor

LGTM

@codecov-io
Copy link
Copy Markdown

Current coverage is 53.60%

Merging #1380 into master will decrease coverage by -4.23% as of acf02be

@@            master   #1380   diff @@
======================================
  Files          123     123       
  Stmts        11155   11156     +1
  Branches       780     709    -71
  Methods          0       0       
======================================
- Hit           6451    5980   -471
+ Partial        780     709    -71
- Missed        3924    4467   +543

Review entire Coverage Diff as of acf02be


Uncovered Suggestions

  1. +0.29% via ...ge/driver/gcs/gcs.go#182...213
  2. +0.24% via ...ge/driver/gcs/gcs.go#85...111
  3. +0.21% via ...ge/driver/gcs/gcs.go#471...494
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

@stevvooe
Copy link
Copy Markdown
Collaborator

LGTM

stevvooe added a commit that referenced this pull request Jan 20, 2016
Avoid empty Accept headers in client requests
@stevvooe stevvooe merged commit 0865082 into distribution:master Jan 20, 2016
aaronlehmann pushed a commit to aaronlehmann/docker that referenced this pull request Jan 20, 2016
@aaronlehmann aaronlehmann deleted the avoid-empty-accept-header branch January 20, 2016 23:46
tiborvass pushed a commit to tiborvass/docker that referenced this pull request Jan 26, 2016
aditirajagopal pushed a commit to aditirajagopal/docker that referenced this pull request Feb 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants