Handle nonstandard token endpoint errors#1379
Merged
stevvooe merged 1 commit intodistribution:masterfrom Jan 20, 2016
Merged
Conversation
distribution#1249 changed token fetching to parse HTTP error response bodies as serialized errcodes. However, Docker Hub's authentication endpoint does not return error bodies in this format. To work around this, convert its format into ErrCodeUnauthorized or ErrCodeUnknown. Signed-off-by: Aaron Lehmann <[email protected]>
Collaborator
|
LGTM |
Contributor
|
LGTM |
1 similar comment
Collaborator
|
LGTM |
Current coverage is
|
stevvooe
added a commit
that referenced
this pull request
Jan 20, 2016
Handle nonstandard token endpoint errors
aaronlehmann
pushed a commit
to aaronlehmann/docker
that referenced
this pull request
Jan 20, 2016
The only changes are distribution/distribution#1379 and distribution/distribution#1380. Fixes moby#19476 Signed-off-by: Aaron Lehmann <[email protected]>
tiborvass
pushed a commit
to tiborvass/docker
that referenced
this pull request
Jan 26, 2016
The only changes are distribution/distribution#1379 and distribution/distribution#1380. Fixes moby#19476 Signed-off-by: Aaron Lehmann <[email protected]>
aditirajagopal
pushed a commit
to aditirajagopal/docker
that referenced
this pull request
Feb 8, 2016
The only changes are distribution/distribution#1379 and distribution/distribution#1380. Fixes moby#19476 Signed-off-by: Aaron Lehmann <[email protected]>
thaJeztah
pushed a commit
to thaJeztah/distribution
that referenced
this pull request
Apr 22, 2021
Handle nonstandard token endpoint errors
thaJeztah
pushed a commit
to thaJeztah/distribution
that referenced
this pull request
Jan 19, 2022
Handle nonstandard token endpoint errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1249 changed token fetching
to parse HTTP error response bodies as serialized errcodes. However,
Docker Hub's authentication endpoint does not return error bodies in
this format. To work around this, convert its format into
ErrCodeUnauthorized or ErrCodeUnknown.
Fixes #1373
See also moby/moby#19476