Fix avatar sync for a SSO #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for this PR! We're going to run some tests against it and hopefully release an update which includes it tomorrow. |
Contributor
|
@klaufel We finished testing and your PR made it into the recent 3.0.16 release, https://wordpress.org/plugins/disqus-comment-system/#developers. Thank you! |
|
Thank you so much for this fix! I contacted disqus support last year about this issue and they told me that the problem was my server ¬¬ well, not a problem anymore :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on the web "http://nintenderos.com" we were having an avatars synchronization problem. Reading the official documentation of Disqus I observed that the value of the parameter that is required in the configuration "avatar" is a url and the function that currently exists
get_avatar()returns<img src="...">when it should return a string with a url.Image with Disqus documentation:
I have modified the function by
get_avatar_url()so that it always returns the url of the avatar, so when the avatar value is updated it will show the new avatar.