DEV: Docker development improvements #13117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes plugins directories will end up with other symlinks (e.g. inside node_modules folders). This logic does not work with deeply nested symlinks, and they are unlikely to be necessary for the plugin to work. Therefore we should only look for symlinks in the top-level of the `plugins` directory
- Add `d/ember-cli`, and publish port 4200 - Remove `d/sidekiq`. Sidekiq is now started with the rails server - Move all `docker exec` logic into a single place, so we have one place to set environment variable pass-throughs - Use `exec` for all bash scripts, so that return statuses are passed back correctly - Avoid using `bin/bash -c` unnecessarily, because it makes escaping arguments difficult
Running a development environment using Docker's qemu architecture emulation is currently not possible because `inotify` is not supported: docker/for-mac#5321
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: |
davidtaylorhq
requested review from
cvx and
eviltrout
and removed request for
eviltrout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEV: Only mount top-level plugin symlinks
Sometimes plugins directories will end up with other symlinks (e.g. inside node_modules folders). This logic does not work with deeply nested symlinks, and they are unlikely to be necessary for the plugin to work. Therefore we should only look for symlinks in the top-level of the
pluginsdirectoryDEV: Update docker development binstubs
d/ember-cli, and publish port 4200d/sidekiq. Sidekiq is now started with the rails serverdocker execlogic into a single place, so we have one place to set environment variable pass-throughsexecfor all bash scripts, so that return statuses are passed back correctlybin/bash -cunnecessarily, because it makes escaping arguments difficultDEV: Add non-x86_64 warning to
d/boot_devRunning a development environment using Docker's qemu architecture emulation is currently not possible because
inotifyis not supported: In docker desktop preview, the inotify function fails on a container with platform set to linux/amd64. docker/for-mac#5321