Skip to content

chore: Merge builders/1.x into v14 #11260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Jiralite merged 4 commits into from
Nov 8, 2025
Merged

chore: Merge builders/1.x into v14 #11260

Jiralite merged 4 commits into from
Nov 8, 2025

Conversation

@Jiralite
Copy link
Member

@Jiralite Jiralite commented Nov 8, 2025 •
edited
Loading

Will make the builders/1.x branch redundant.

@vercel
Copy link

vercel bot commented Nov 8, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
discord-js Ignored Ignored Preview Nov 8, 2025 11:23pm
discord-js-guide Ignored Ignored Preview Nov 8, 2025 11:23pm

@codecov
Copy link

codecov bot commented Nov 8, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 81.58537% with 151 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.99%. Comparing base (e382d60) to head (73bc314).
⚠️ Report is 41 commits behind head on v14.

Files with missing lines Patch % Lines
packages/builders/src/components/label/Label.ts 14.94% 74 Missing ⚠️
packages/builders/src/interactions/modals/Modal.ts 33.75% 53 Missing ⚠️
...s/builders/src/components/selectMenu/Assertions.ts 87.95% 10 Missing ⚠️
...s/builders/src/components/fileUpload/FileUpload.ts 83.33% 6 Missing ⚠️
packages/builders/src/components/Components.ts 91.30% 4 Missing ⚠️
...ilders/src/components/selectMenu/BaseSelectMenu.ts 40.00% 3 Missing ⚠️
packages/builders/src/components/v2/Assertions.ts 98.24% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              v14   #11260      +/-   ##
==========================================
+ Coverage   35.61%   37.99%   +2.38%     
==========================================
  Files         228      242      +14     
  Lines       14312    15091     +779     
  Branches     1260     1361     +101     
==========================================
+ Hits         5097     5734     +637     
- Misses       9171     9313     +142     
  Partials       44       44
Flag Coverage Δ
builders 88.06% <81.58%> (-3.53%) ⬇️
formatters 97.43% <ø> (ø)
proxy 66.27% <ø> (ø)
rest 88.14% <ø> (ø)
voice 63.64% <ø> (ø)
ws 36.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Jiralite Jiralite force-pushed the chore/merge-builders-to-v14 branch from 551ad69 to 0d8711a Compare November 8, 2025 23:18
@Jiralite Jiralite added the chore label Nov 8, 2025
@Jiralite Jiralite marked this pull request as ready for review November 8, 2025 23:19
@Jiralite Jiralite requested review from a team and iCrawl as code owners November 8, 2025 23:19
@Jiralite Jiralite requested review from SpaceEEC, almeidx, didinele, kyranet and vladfrangu and removed request for a team November 8, 2025 23:19
@Jiralite Jiralite requested review from a team as code owners November 8, 2025 23:22
@Jiralite Jiralite requested review from ckohen and removed request for a team November 8, 2025 23:22
@Jiralite Jiralite changed the title chore: Merge builders (and formatters) chore: Merge builders/1.x into v14 Nov 8, 2025
@Jiralite Jiralite merged commit b6a8264 into v14 Nov 8, 2025
29 checks passed
@Jiralite Jiralite deleted the chore/merge-builders-to-v14 branch November 8, 2025 23:31
@github-project-automation github-project-automation bot moved this from Todo to Done in discord.js Nov 8, 2025
@Jiralite Jiralite mentioned this pull request Nov 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner

@vladfrangu vladfrangu Awaiting requested review from vladfrangu vladfrangu is a code owner automatically assigned from discordjs/formatters

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/formatters

@almeidx almeidx Awaiting requested review from almeidx almeidx is a code owner automatically assigned from discordjs/formatters

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

@didinele didinele Awaiting requested review from didinele didinele is a code owner automatically assigned from discordjs/builders

@ckohen ckohen Awaiting requested review from ckohen ckohen is a code owner automatically assigned from discordjs/rest

Assignees

No one assigned

Labels

chore packages:builders packages:core packages:discord.js packages:formatters packages:next packages:rest packages:voice packages:ws

Projects

discord.js
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Jiralite