Skip to content

feat(GuildMemberManager): handle gateway request rate limit #11253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Jiralite merged 5 commits into from
Nov 17, 2025
Merged

feat(GuildMemberManager): handle gateway request rate limit #11253

Jiralite merged 5 commits into from
Nov 17, 2025
+71 −20

Conversation

@didinele
Copy link
Member

@didinele didinele commented Nov 5, 2025

Backports #11252

@didinele didinele requested a review from a team as a code owner November 5, 2025 19:46
@didinele didinele requested review from SpaceEEC, iCrawl, kyranet and vladfrangu and removed request for a team November 5, 2025 19:46
@vercel
Copy link

vercel bot commented Nov 5, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
discord-js Error Error Nov 16, 2025 7:18pm
discord-js-guide Error Error Nov 16, 2025 7:18pm

@Jiralite Jiralite self-requested a review November 6, 2025 16:43
@Jiralite Jiralite added this to the discord.js 14.25.0 milestone Nov 6, 2025
@didinele didinele mentioned this pull request Nov 10, 2025
Merged
@codecov
Copy link

codecov bot commented Nov 10, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 36.98%. Comparing base (ccbe071) to head (353db6b).

Additional details and impacted files 
@@           Coverage Diff           @@
##              v14   #11253   +/-   ##
=======================================
  Coverage   36.98%   36.98%           
=======================================
  Files         242      242           
  Lines       14847    14847           
  Branches     1368     1368           
=======================================
  Hits         5491     5491           
  Misses       9312     9312           
  Partials       44       44
Flag Coverage Δ
brokers 27.71% <ø> (ø)
builders 86.88% <ø> (ø)
collection 100.00% <ø> (ø)
formatters 97.65% <ø> (ø)
proxy 64.63% <ø> (ø)
rest 87.75% <ø> (ø)
util 41.42% <ø> (ø)
utilities 100.00% <ø> (ø)
voice 63.64% <ø> (ø)
ws 34.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

vladfrangu
vladfrangu reviewed Nov 11, 2025
View reviewed changes
@didinele
Copy link
Member Author

didinele commented Nov 11, 2025

Waiting on #11252 so we know for sure what our approach is.

@Jiralite Jiralite changed the title feat(GuildMemberManager): handle gateway request ratelimit feat(GuildMemberManager): handle gateway request rate limit Nov 14, 2025
@Jiralite Jiralite mentioned this pull request Nov 16, 2025
Open
@Jiralite Jiralite requested a review from a team as a code owner November 16, 2025 18:46
@Jiralite Jiralite requested review from almeidx, sdanialraza and vladfrangu and removed request for a team November 16, 2025 18:46
@Jiralite Jiralite force-pushed the feat/14-mainlib-fetch-g-member-limit branch from d432389 to 44a2dd3 Compare November 16, 2025 18:47
@sdanialraza sdanialraza removed their request for review November 16, 2025 18:48
@github-project-automation github-project-automation bot moved this from Todo to Review Approved in discord.js Nov 16, 2025
@Jiralite Jiralite merged commit a3c6bce into v14 Nov 17, 2025
6 of 8 checks passed
@github-project-automation github-project-automation bot moved this from Review Approved to Done in discord.js Nov 17, 2025
@Jiralite Jiralite deleted the feat/14-mainlib-fetch-g-member-limit branch November 17, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@Jiralite Jiralite Jiralite approved these changes

@Qjuh Qjuh Qjuh approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

@almeidx almeidx Awaiting requested review from almeidx almeidx was automatically assigned from discordjs/util

Assignees

No one assigned

Labels

api support backport gateway packages:discord.js semver:minor

Projects

discord.js
Archived in project

Milestone

discord.js 14.25.0

Development

Successfully merging this pull request may close these issues.

5 participants

@didinele @vladfrangu @Jiralite @Qjuh