Skip to content

feat(core): handle request all guild members rate limit #11251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kodiakhq merged 8 commits into from
Nov 11, 2025
Merged

feat(core): handle request all guild members rate limit #11251

kodiakhq merged 8 commits into from
Nov 11, 2025

Conversation

@didinele
Copy link
Member

@didinele didinele commented Nov 5, 2025 •
edited
Loading

No description provided.

@didinele
feat(core): handle request all guild members rate limit
be1bbdc 
BREAKING CHANGE: `Gateway` now requires `off` `once` methods
@didinele
fix: weird import update
f618add
@didinele didinele requested a review from a team as a code owner November 5, 2025 18:37
@vercel
Copy link

vercel bot commented Nov 5, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
discord-js Ignored Ignored Preview Nov 11, 2025 7:11am
discord-js-guide Ignored Ignored Preview Nov 11, 2025 7:11am

@codecov
Copy link

codecov bot commented Nov 5, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 3.84615% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.64%. Comparing base (9723cc5) to head (59bf5dd).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
packages/core/src/client.ts 0.00% 17 Missing ⚠️
packages/util/src/gatewayRateLimitError.ts 11.11% 8 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11251      +/-   ##
==========================================
+ Coverage   44.41%   44.64%   +0.23%     
==========================================
  Files         315      316       +1     
  Lines       18140    18079      -61     
  Branches     1810     1804       -6     
==========================================
+ Hits         8057     8072      +15     
+ Misses      10071     9995      -76     
  Partials       12       12
Flag Coverage Δ
builders 80.60% <ø> (+0.85%) ⬆️
core 0.90% <0.00%> (-0.01%) ⬇️
proxy 65.88% <ø> (ø)
rest 87.56% <ø> (ø)
util 39.47% <11.11%> (-3.81%) ⬇️
ws 35.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Jiralite Jiralite modified the milestones: core 2.4.0, core 3.0.0 Nov 5, 2025
Jiralite
Jiralite reviewed Nov 5, 2025
View reviewed changes
@Jiralite Jiralite self-requested a review November 6, 2025 16:45
Jiralite
Jiralite reviewed Nov 6, 2025
View reviewed changes
@Jiralite Jiralite mentioned this pull request Nov 6, 2025
Merged
@didinele didinele changed the title feat(core)!: handle request all guild members rate limit feat(core): handle request all guild members rate limit Nov 10, 2025
@didinele didinele requested a review from a team as a code owner November 10, 2025 13:38
@didinele didinele requested review from Jiralite and almeidx November 10, 2025 13:38
@didinele didinele requested a review from sdanialraza November 10, 2025 13:38
almeidx
almeidx reviewed Nov 10, 2025
View reviewed changes
Qjuh
Qjuh approved these changes Nov 10, 2025
View reviewed changes
Copy link
Member

@Qjuh Qjuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from dtypes as dependency LGTM

@didinele didinele requested a review from almeidx November 10, 2025 18:07
almeidx
almeidx approved these changes Nov 10, 2025
View reviewed changes
vladfrangu
vladfrangu requested changes Nov 10, 2025
View reviewed changes
@github-project-automation github-project-automation bot moved this from Todo to Review in Progress in discord.js Nov 10, 2025
@didinele didinele requested a review from vladfrangu November 10, 2025 21:27
@github-project-automation github-project-automation bot moved this from Review in Progress to Review Approved in discord.js Nov 11, 2025
@kodiakhq kodiakhq bot merged commit d3d6777 into main Nov 11, 2025
27 checks passed
@kodiakhq kodiakhq bot deleted the feat/core-handle-all-member-ratelimit branch November 11, 2025 07:14
@github-project-automation github-project-automation bot moved this from Review Approved to Done in discord.js Nov 11, 2025
Jiralite pushed a commit that referenced this pull request Nov 12, 2025
@didinele @kodiakhq @Jiralite
feat(core): handle request all guild members rate limit (#11251)
5c5b545 
* feat(core): handle request all guild members rate limit

* fix: weird import update

* refactor: error class

* refactor: error class again

* refactor: requested changes

* chore: fix dep

* fix: suggested changes

---------

Co-Authored-By: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@almeidx almeidx almeidx approved these changes

@vladfrangu vladfrangu vladfrangu approved these changes

@Jiralite Jiralite Jiralite approved these changes

@Qjuh Qjuh Qjuh approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

@sdanialraza sdanialraza Awaiting requested review from sdanialraza sdanialraza is a code owner automatically assigned from discordjs/util

Assignees

No one assigned

Labels

api support packages:core packages:util ratelimits semver:minor

Projects

discord.js
Archived in project

Milestone

core 3.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@didinele @vladfrangu @Jiralite @almeidx @Qjuh