Skip to content

fix: only pass relevant options to API when fetching #11228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kodiakhq merged 3 commits into from
Oct 31, 2025
Merged

fix: only pass relevant options to API when fetching #11228

kodiakhq merged 3 commits into from
Oct 31, 2025

Conversation

@sdanialraza
Copy link
Member

@sdanialraza sdanialraza commented Oct 31, 2025

Please describe the changes this PR makes and why it should be merged:
Resolves #11227

@sdanialraza sdanialraza requested a review from a team as a code owner October 31, 2025 17:12
@vercel
Copy link

vercel bot commented Oct 31, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
discord-js Ignored Ignored Preview Oct 31, 2025 8:25pm
discord-js-guide Ignored Ignored Preview Oct 31, 2025 8:25pm

@imnaiyar imnaiyar mentioned this pull request Oct 31, 2025
Merged
Jiralite
Jiralite requested changes Oct 31, 2025
View reviewed changes
Copy link
Member

@Jiralite Jiralite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do something like this instead:

async _fetchMany({ cache, ...apiOptions } = {}) {

@github-project-automation github-project-automation bot moved this from Todo to Review in Progress in discord.js Oct 31, 2025
@sdanialraza sdanialraza requested a review from Jiralite October 31, 2025 17:54
Jiralite
Jiralite requested changes Oct 31, 2025
View reviewed changes
Copy link
Member

@Jiralite Jiralite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed instance:

discord.js/packages/discord.js/src/managers/MessageManager.js

Lines 165 to 171 in d06d8c0

async fetchPins(options = {}) {
const data = await this.client.rest.get(Routes.channelMessagesPins(this.channel.id), {
query: makeURLSearchParams({
...options,
before: options.before && new Date(options.before).toISOString(),
}),
});

@github-project-automation github-project-automation bot moved this from Review in Progress to Review Approved in discord.js Oct 31, 2025
@kodiakhq kodiakhq bot merged commit f26a5ed into main Oct 31, 2025
8 checks passed
@github-project-automation github-project-automation bot moved this from Review Approved to Done in discord.js Oct 31, 2025
@kodiakhq kodiakhq bot deleted the fix/only-pass-relevant-options-fetching branch October 31, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ckohen ckohen ckohen approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@Jiralite Jiralite Jiralite approved these changes

@vladfrangu vladfrangu Awaiting requested review from vladfrangu vladfrangu is a code owner automatically assigned from discordjs/core

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

+1 more reviewer

@imnaiyar imnaiyar imnaiyar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport-candidate packages:discord.js semver:patch

Projects

discord.js
Archived in project

Milestone

discord.js 15.0.0

Development

Successfully merging this pull request may close these issues.

MessageManager._fetchMany passes options to the Discord API without considering if they are internal to discord.js

5 participants

@sdanialraza @ckohen @SpaceEEC @Jiralite @imnaiyar