fix(interactions): wrong return type and missing implementation of with_response in core #10644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Jiralite
changed the title
Jiralite
previously approved these changes
Dec 8, 2024
imnaiyar
changed the title
Jiralite
approved these changes
Dec 8, 2024
kyranet
approved these changes
Dec 9, 2024
didinele
approved these changes
Dec 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10644 +/- ##
==========================================
- Coverage 37.10% 37.09% -0.02%
==========================================
Files 239 239
Lines 15212 15208 -4
Branches 1373 1371 -2
==========================================
- Hits 5645 5641 -4
Misses 9556 9556
Partials 11 11 ☔ View full report in Codecov by Sentry. |
imnaiyar
added a commit
to imnaiyar/discord.js
that referenced
this pull request
Dec 9, 2024
…th_response in core (discordjs#10644) * fix(types): wrong return type with with_response * fix: missing implementation of with_response --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Jiralite
pushed a commit
that referenced
this pull request
Nov 12, 2025
…th_response in core (#10644) * fix(types): wrong return type with with_response * fix: missing implementation of with_response --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
with_responsewas missing implementations in some methods and wrong return types due to #10512.Status and versioning classification: