Skip to content

fix: query is optional for some endpoints #10621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kodiakhq merged 2 commits into from
Nov 28, 2024
Merged

fix: query is optional for some endpoints #10621

kodiakhq merged 2 commits into from
Nov 28, 2024

Conversation

@Jiralite
Copy link
Member

@Jiralite Jiralite commented Nov 27, 2024 •
edited
Loading

Please describe the changes this PR makes and why it should be merged:
Nothing in these query options are required, so they have been defaulted to {}.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@Jiralite Jiralite added this to the core 2.1.0 milestone Nov 27, 2024
@Jiralite Jiralite requested a review from a team as a code owner November 27, 2024 19:30
@vercel
Copy link

vercel bot commented Nov 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2024 8:00pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2024 8:00pm

almeidx
almeidx previously requested changes Nov 27, 2024
View reviewed changes
Copy link
Member

@almeidx almeidx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's more

discord.js/packages/core/src/api/poll.ts

Line 29 in e89c6b6

query: RESTGetAPIPollAnswerVotersQuery,

discord.js/packages/core/src/api/monetization.ts

Line 41 in e89c6b6

query: RESTGetAPISKUSubscriptionsQuery,

@Jiralite Jiralite changed the title fix(monetization): query is optional for getting entitlements fix: query is optional for some endpoints Nov 27, 2024
@Jiralite Jiralite requested a review from almeidx November 27, 2024 20:00
@kodiakhq kodiakhq bot merged commit 9010b12 into main Nov 28, 2024
12 checks passed
@kodiakhq kodiakhq bot deleted the fix/optional-get-entitlements branch November 28, 2024 08:11
@Jiralite Jiralite modified the milestones: core 2.1.0, core 3.0.0 Dec 8, 2024
Jiralite added a commit that referenced this pull request Nov 12, 2025
@Jiralite
fix: query is optional for some endpoints (#10621)
610b4bb 
* fix(monetization): `query` is optional

* refactor: more defaults
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@didinele didinele didinele approved these changes

@almeidx almeidx almeidx approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

Assignees

No one assigned

Labels

packages:core semver:patch

Projects

discord.js
Archived in project

Milestone

core 3.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Jiralite @vladfrangu @didinele @almeidx