types: Export some core-specific types #10620
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
We have methods like
ChannelsAPI#createMessage(),InteractionsAPI#reply(),InteractionsAPI#updateMessage(), etc. where the body parameters are of types that intersect with objects. That means we have to do this as they are not exported:The reason for this is because
contentis conditionally present. We cannot type this asRESTPostAPIChannelMessageJSONBodybecausefilesis not there. This is a @discordjs/core-specific type.Doing
Parameters<ChannelsAPI["createMessage"]>[1]is not ideal as when the library introduces minor or major changes, parameters may shift which results in yet again browsing the source code to see the intersected types. These types should be exported for ease.Status and versioning classification: