Skip to content

Conversation

@sdanialraza
Copy link
Member

@sdanialraza sdanialraza commented Sep 5, 2024

Please describe the changes this PR makes and why it should be merged:
Adds subscriptions for core

Depends on changes from:

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@vercel
Copy link

vercel bot commented Sep 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 4, 2024 10:46am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Nov 4, 2024 10:46am

@Jiralite Jiralite added this to the core 1.4.0 milestone Oct 1, 2024
@sdanialraza sdanialraza marked this pull request as ready for review October 1, 2024 14:04
@sdanialraza sdanialraza requested a review from a team as a code owner October 1, 2024 14:04
Copy link
Member

@almeidx almeidx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sdanialraza sdanialraza requested a review from almeidx October 3, 2024 22:22
@kodiakhq kodiakhq bot merged commit 1fd6626 into discordjs:main Nov 4, 2024
7 checks passed
@codecov
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 35.15%. Comparing base (ed78e45) to head (f95b6d9).
⚠️ Report is 408 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10486      +/-   ##
==========================================
- Coverage   38.01%   35.15%   -2.86%     
==========================================
  Files         239      240       +1     
  Lines       15471    14523     -948     
  Branches     1353     1200     -153     
==========================================
- Hits         5881     5106     -775     
+ Misses       9575     9370     -205     
- Partials       15       47      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sdanialraza sdanialraza deleted the feat/add-subscriptions branch November 5, 2024 18:01
@Jiralite Jiralite removed this from the core 2.1.0 milestone Dec 8, 2024
@Jiralite Jiralite added this to the core 3.0.0 milestone Dec 8, 2024
Jiralite pushed a commit that referenced this pull request Nov 12, 2025
* feat: add subscriptions

* docs: requested changes

Co-authored-by: Almeida <[email protected]>

---------

Co-authored-by: Almeida <[email protected]>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants