Mark File component name/size fields as optional#8153
Merged
Conversation
Both fields are server-populated from the referenced attachment and cannot be provided by clients. They should be marked optional to match the convention used by similar server-populated fields on Unfurled Media Item (proxy_url?, height?, width?, etc.). Fixes #8152
brad-discord
marked this pull request as ready for review
February 19, 2026 18:35
brad-discord
requested review from
colinloretz
and removed request for
a team
February 19, 2026 18:35
advaith1
approved these changes
Feb 19, 2026
Contributor
|
@brad-discord would you be kind enough to satisfy my curiosity — what is “selentic”? |
xavier-archlinux-tw
pushed a commit
to xavier-archlinux-tw/discord-api-docs
that referenced
this pull request
Jul 14, 2026
Both fields are server-populated from the referenced attachment and cannot be provided by clients. They should be marked optional to match the convention used by similar server-populated fields on Unfurled Media Item (proxy_url?, height?, width?, etc.). Fixes discord#8152
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marks
nameandsizeas optional (?) in the File component documentation table.Both fields are server-populated from the referenced attachment and cannot be provided by clients. The descriptions already say "This field is ignored and provided by the API as part of the response", but the field names were missing the
?suffix that similar server-populated fields.Fixes #8152