Skip to content

Components v2#7487

Merged
anthonydiscord merged 1 commit into
mainfrom
components-v2
Apr 22, 2025
Merged

Components v2#7487
anthonydiscord merged 1 commit into
mainfrom
components-v2

Conversation

@anthonydiscord

@anthonydiscord anthonydiscord commented Apr 22, 2025

Copy link
Copy Markdown
Contributor

Adding documentation, changelog, and links updates for components v2. The interactions.js library and samples using it are going to follow in another PR.

@anthonydiscord
anthonydiscord requested a review from a team as a code owner April 22, 2025 01:48
@anthonydiscord
anthonydiscord requested review from colinloretz and markmandel and removed request for a team and markmandel April 22, 2025 01:48
Comment thread docs/components/overview.mdx Outdated
Comment thread docs/components/reference.mdx Outdated
Comment thread docs/change-log/2025-04-21-components-v2.md Outdated

@Lulalaby Lulalaby left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following message is repeated really often:

> info
> To use this component, you need to send the [message flag](/docs/resources/message#message-object-message-flags) `1 << 15` (IS_COMPONENTS_V2) which can be activated on a per-message basis.

Might it be better to just specify a version number in the heading, linking to "this needs flag xy"?

Anyways, I really love how the docs turned out. Might've overseen something. Will look a bit later again.
The suggestions should catch most > info parts and change them to :::info as Justin mentioned.
Also discussion point: Putting IS_COMPONENTS_V2 into ` IS_COMPONENTS_V2

Since I was asked to review

Comment thread docs/change-log/2025-04-21-components-v2.md Outdated
Comment thread docs/components/overview.mdx Outdated
Comment thread docs/components/reference.mdx Outdated
Comment on lines +52 to +56
| 13 | [File](/docs/components/reference#file) | Displays an attached file | Content | Message |
| 14 | [Separator](/docs/components/reference#separator) | Component to add vertical padding between other components | Layout | Message |
| 17 | [Container](/docs/components/reference#container) | Container that visually groups a set of components | Layout | Message |

@Lulalaby Lulalaby Apr 22, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we decided against including the content inventory type (it can be received) as reference?

Comment thread docs/components/reference.mdx Outdated
Comment thread docs/components/reference.mdx Outdated
Comment thread docs/components/reference.mdx Outdated
Comment thread docs/components/reference.mdx Outdated
Comment thread docs/components/using-modal-components.mdx Outdated
Comment thread docs/monetization/managing-skus.mdx Outdated
Comment thread docs/components/overview.mdx Outdated

@Icebluewolf Icebluewolf left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wanted to point out a few things I saw :)
Sorry, if these are overly nit-picky.

Comment thread docs/components/reference.mdx Outdated
Comment thread docs/components/using-message-components.mdx
Comment thread docs/components/reference.mdx Outdated
Comment thread docs/components/using-modal-components.mdx Outdated
Comment thread docs/resources/message.md Outdated

@Lulalaby Lulalaby left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, since it came up again on our lib server: It should be mentioned that components (namely text display) can mention users and roles.

Comment thread docs/components/reference.mdx Outdated
Comment thread docs/components/reference.mdx Outdated
Comment thread docs/resources/message.md Outdated
Comment thread docs/components/overview.mdx Outdated
Comment thread docs/components/reference.mdx Outdated
Comment thread docs/components/reference.mdx Outdated
Comment thread docs/components/reference.mdx Outdated
@DA-344 DA-344 mentioned this pull request Apr 22, 2025
6 tasks
@anthonydiscord
anthonydiscord force-pushed the components-v2 branch 2 times, most recently from 07ceead to 51517d4 Compare April 22, 2025 14:24
Comment thread docs/change-log/2025-04-22-components-v2.md Outdated
Comment thread docs/change-log/2025-04-22-components-v2.md Outdated
Comment thread docs/change-log/2025-04-22-components-v2.md Outdated
Comment thread docs/components/using-message-components.mdx Outdated
Comment thread docs/components/using-message-components.mdx
Comment thread docs/components/using-message-components.mdx Outdated
Comment thread docs/components/using-message-components.mdx Outdated
Comment thread docs/components/reference.mdx Outdated
Comment thread docs/components/reference.mdx Outdated
Comment thread docs/components/reference.mdx
Comment thread docs/components/reference.mdx Outdated

@colinloretz colinloretz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@anthonydiscord
anthonydiscord merged commit af1843d into main Apr 22, 2025
@anthonydiscord
anthonydiscord deleted the components-v2 branch April 22, 2025 20:10

@JustinBeckwith JustinBeckwith left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"just let me sneak one more merge conflict in first"

@JustinBeckwith

Copy link
Copy Markdown
Contributor

dammit it too late

mazylol pushed a commit to mazylol/discord-api-docs that referenced this pull request Jul 3, 2025
xavier-archlinux-tw pushed a commit to xavier-archlinux-tw/discord-api-docs that referenced this pull request Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants