fix(subagent): defer critic, ignore blank retry task ids#679
Merged
Conversation
Normalize optional retry identifiers at the task-tool boundary so empty or whitespace-only values behave like omitted fields. This keeps generated tool calls from entering coordinator retry validation for a nonexistent task while preserving the existing one-retry policy for real IDs. Deliberately keep strict validation for nonblank IDs and trim surrounding whitespace rather than weakening coordinator admission rules. Verified: regression and coordinator retry tests pass; fmt and clippy clean; full binary suite passes excluding live h7_glm; binary builds.
Treat a nonterminal coordinator generation as an intentional suspension rather than a completion candidate. This keeps the critic and other finalization gates from reviewing an interim response that merely announces background work. Give completed batch delivery priority over deferral so a task finishing at the finalization boundary is reconciled immediately. Preserve the existing UI wakeup path instead of polling from the parent loop or weakening critic completeness checks. Verified: fmt and clippy clean; binary tests pass excluding live h7_glm; normal and windows-default builds pass.
Match the rest of LoopConfig — every other field/hook type carries a doc comment. No behavior change.
allen-munsch
pushed a commit
to allen-munsch/dirge
that referenced
this pull request
Jul 18, 2026
Defer the critic on a parent turn waiting for coordinated subagents, and normalize blank task retry ids (dirge-code#679). Also backfill CHANGELOG: coordinated subagent dispatch (dirge-code#670) under 0.19.10 and the OpenCode reasoning fix (dirge-code#671) under 0.19.9, which shipped but weren't recorded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normalize optional retry identifiers at the task-tool boundary so empty or whitespace-only values behave like omitted fields. This keeps generated tool calls from entering coordinator retry validation for a nonexistent task while preserving the existing one-retry policy for real IDs.
Deliberately keep strict validation for nonblank IDs and trim surrounding whitespace rather than weakening coordinator admission rules.
Verified: regression and coordinator retry tests pass; fmt and clippy clean; full binary suite passes excluding live h7_glm; binary builds.
Normalize optional retry identifiers at the task-tool boundary so empty or whitespace-only values behave like omitted fields. This keeps generated tool calls from entering coordinator retry validation for a nonexistent task while preserving the existing one-retry policy for real IDs.
Deliberately keep strict validation for nonblank IDs and trim surrounding whitespace rather than weakening coordinator admission rules.
Verified: regression and coordinator retry tests pass; fmt and clippy clean; full binary suite passes excluding live h7_glm; binary builds.