Skip to content

fix: opencode reasoning profile matches DeepSeek API shape#671

Merged
yogthos merged 2 commits into
dirge-code:mainfrom
gretel:fix/opencode-reasoning-profile
Jul 15, 2026
Merged

fix: opencode reasoning profile matches DeepSeek API shape#671
yogthos merged 2 commits into
dirge-code:mainfrom
gretel:fix/opencode-reasoning-profile

Conversation

@gretel

@gretel gretel commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

OpenCode at https://opencode.ai/zen/v1 proxies to DeepSeek models, but its reasoning profile used GenericLevel (reasoning_level) and ChatTemplateKwargs (chat_template_kwargs) — the vLLM/SGLang self-hosted keys that DeepSeek's hosted API ignores.

Switch to TopLevelEffort (reasoning_effort) + ThinkingToggle (thinking: {type: disabled}), matching the built-in DeepSeek provider. This enables both deep thinking mode and correct one-shot disable.

OpenCode at https://opencode.ai/zen/v1 proxies to DeepSeek models,
but its reasoning profile used GenericLevel (reasoning_level) and
ChatTemplateKwargs (chat_template_kwargs) — the vLLM/SGLang
self-hosted keys that DeepSeek's hosted API ignores.

Switch to TopLevelEffort (reasoning_effort) + ThinkingToggle
(thinking: {type: disabled}), matching the built-in DeepSeek provider.
This enables both deep thinking mode and correct one-shot disable.
@yogthos

yogthos commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Looks good, if you can fix a few errors in the CI, happy to merge it in.

The reasoning_disable_shapes_per_provider test had opencode listed
under the old chat_template_kwargs assertion. Move it to the
thinking:{type:disabled} group to match the profile change.
@yogthos
yogthos merged commit f540392 into dirge-code:main Jul 15, 2026
13 checks passed
@gretel

gretel commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

Looks good, if you can fix a few errors in the CI, happy to merge it in.

thanks!

@gretel
gretel deleted the fix/opencode-reasoning-profile branch July 15, 2026 19:43
@yogthos

yogthos commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the PR, I'll roll it into the next release today or tomorrow.

@gretel

gretel commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

side note: this change is not showing up in the changelog.

@yogthos

yogthos commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

oh right, let me update that

yogthos pushed a commit that referenced this pull request Jul 17, 2026
Defer the critic on a parent turn waiting for coordinated subagents, and
normalize blank task retry ids (#679). Also backfill CHANGELOG: coordinated
subagent dispatch (#670) under 0.19.10 and the OpenCode reasoning fix (#671)
under 0.19.9, which shipped but weren't recorded.
@gretel

gretel commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

oh right, let me update that

thanks! building from source on a macbook neo is tough so i'm using the binaries here.

@yogthos

yogthos commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

yeah the big downside with Rust is that build times get kind of insane

@gretel

gretel commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

yeah the big downside with Rust is that build times get kind of insane

yeah. i was hoping for things to improve over time..

@yogthos

yogthos commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

same...

@gretel

gretel commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

@yogthos

yogthos commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

I did one round, but I think could probably revisit that again

allen-munsch pushed a commit to allen-munsch/dirge that referenced this pull request Jul 18, 2026
Defer the critic on a parent turn waiting for coordinated subagents, and
normalize blank task retry ids (dirge-code#679). Also backfill CHANGELOG: coordinated
subagent dispatch (dirge-code#670) under 0.19.10 and the OpenCode reasoning fix (dirge-code#671)
under 0.19.9, which shipped but weren't recorded.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants