Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
br41nslug
commented
Oct 22, 2025
2 tasks
Co-authored-by: daedalus <[email protected]>
ComfortablyCoding
requested changes
Oct 22, 2025
Member
There was a problem hiding this comment.
Ideally we mention:
- While they will be dropped when the queue is full, sending notification and the send email operation will not respond with an error.
- A warning to ensure the email queue is appropriately sized as internal emails are also restricted by it.
- Once the queue is full it will error and drop any subsequent calls
- A note that the
Send Emailoperation is also impacted by theRATE_LIMITER_EMAILrestrictions in addition to its ownRATE_LIMITER_EMAIL_FLOWSif applicable.
Co-authored-by: daedalus <[email protected]>
Co-authored-by: daedalus <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the new email rate limiting environment variables created in this PR directus/directus#25966