Skip to content

Fix translation interface disable logic#26669

Merged
AlexGaillard merged 4 commits intodirectus:mainfrom
AlexGaillard:alexgaillard/cms-1818
Feb 16, 2026
Merged

Fix translation interface disable logic#26669
AlexGaillard merged 4 commits intodirectus:mainfrom
AlexGaillard:alexgaillard/cms-1818

Conversation

@AlexGaillard
Copy link
Member

@AlexGaillard AlexGaillard commented Feb 16, 2026

Scope

What's changed:

  • Fixes a regression from Fix inconsistent disabled state across interfaces #26470 which was fully disabling the translation interface when delete permission was not allowed
  • Now the disable logic is seperated out so the entire interface is disabled for !isSaveAllowed and the delete button is disabled when !deleteAllowed

Potential Risks / Drawbacks

  • Probably very little as this partially backtracks to logic we had before

Tested Scenarios

  • The stated issue is no longer occuring

Review Notes / Questions

  • Is there something I'm not seeing?

Checklist

  • Added or updated tests
  • Documentation PR created here or not required
  • OpenAPI package PR created here or not required

Fixes CMS-1818

@AlexGaillard AlexGaillard requested review from HZooly and removed request for HZooly February 16, 2026 21:12
@AlexGaillard AlexGaillard requested a review from formfcw February 16, 2026 21:22
robluton
robluton approved these changes Feb 16, 2026
View reviewed changes
Copy link
Contributor

@robluton robluton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎸

@AlexGaillard AlexGaillard enabled auto-merge (squash) February 16, 2026 21:35
@AlexGaillard AlexGaillard merged commit 6537741 into directus:main Feb 16, 2026
66 checks passed
@github-actions github-actions bot added this to the Next Release milestone Feb 16, 2026
AlexGaillard added a commit that referenced this pull request Feb 18, 2026
@AlexGaillard
Fix translation interface disable logic (#26669)
6574047 
* Separate activator and remove button disable logic

* Add changeset

* Revert "Separate activator and remove button disable logic"

This reverts commit ee3c8f1.

* Only disable entire interface on disabled prop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robluton robluton robluton approved these changes

@formfcw formfcw Awaiting requested review from formfcw

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v11.15.4

Development

Successfully merging this pull request may close these issues.

2 participants

@AlexGaillard @robluton