Skip to content

Fix tree view edit opening multiple drawers#26656

Merged
AlexGaillard merged 3 commits intomainfrom
alexgaillard/cms-1815-editing-item-in-tree-view-opens-multiple-drawers
Feb 13, 2026
Merged

Fix tree view edit opening multiple drawers#26656
AlexGaillard merged 3 commits intomainfrom
alexgaillard/cms-1815-editing-item-in-tree-view-opens-multiple-drawers

Conversation

@AlexGaillard
Copy link
Member

@AlexGaillard AlexGaillard commented Feb 13, 2026

Scope

What's changed:

  • Reverts a questionable change from collaborative editing that causes the tree view edit button to open mutliple drawers

Potential Risks / Drawbacks

  • Tree view for collaborative editing is affected

Tested Scenarios

  • Tested in both collaborative and non-collaborative mode, appears to still work

Review Notes / Questions

  • NA

Checklist

  • Added or updated tests
  • Documentation PR created here or not required
  • OpenAPI package PR created here or not required

Fixes #26654

@AlexGaillard AlexGaillard requested a review from formfcw February 13, 2026 15:44
@linear
Copy link

linear bot commented Feb 13, 2026

Copy link
Member

@HZooly HZooly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the replacement of defineModel by a ref breaks the two-way binding, I think you need to edit the <ItemPreview /> uses:

  • list-o2m-tree-view.vue
  • nested-draggable.vue

and all associated models/refs there.

This avoid dead code that won't be used, behaviour should not change.

Copy link
Member Author

@AlexGaillard AlexGaillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This avoid dead code that won't be used, behaviour should not change.

@HZooly, TY removed the dead code

@AlexGaillard AlexGaillard requested a review from HZooly February 13, 2026 17:22
Copy link
Member

@HZooly HZooly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@AlexGaillard AlexGaillard enabled auto-merge (squash) February 13, 2026 17:29
@AlexGaillard AlexGaillard enabled auto-merge (squash) February 13, 2026 17:33
@AlexGaillard AlexGaillard merged commit 0e03416 into main Feb 13, 2026
71 checks passed
@AlexGaillard AlexGaillard deleted the alexgaillard/cms-1815-editing-item-in-tree-view-opens-multiple-drawers branch February 13, 2026 17:36
@github-actions github-actions bot added this to the Next Release milestone Feb 13, 2026
AlexGaillard added a commit that referenced this pull request Feb 18, 2026
* Revert defineModel change to item-preview

* Add changeset

* Remove dead code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Editing item in tree view open's multiple drawers

2 participants