Fix cockroachdb failing on "Add Marketplace" migration#26467
Merged
AlexGaillard merged 10 commits intomainfrom Jan 14, 2026
Merged
Fix cockroachdb failing on "Add Marketplace" migration#26467AlexGaillard merged 10 commits intomainfrom
cockroachdb failing on "Add Marketplace" migration#26467AlexGaillard merged 10 commits intomainfrom
Conversation
- rename second param from `columns` to `to` - add jsdoc - assert inputs are valid
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
br41nslug
reviewed
Jan 9, 2026
Member
br41nslug
left a comment
br41nslug
left a comment
There was a problem hiding this comment.
Done a quick test with the latest v25 of cockroach and the bootstrap is running without errors 🙌 want to run a few more tests before approving but looking good so far 🚀
br41nslug
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
What's changed:
cockroachdbchangePrimaryKeyfunction with the following changescolumnsparameter totoPotential Risks / Drawbacks
Tested Scenarios
v25.2,v24.3,v24.1,v23.2Review Notes / Questions
Checklist
Fixes #25262
Fixes #23903