use vue instance level 'provide/inject' mechanism for pinia store#26438
Merged
rijkvanzanten merged 9 commits intodirectus:mainfrom Feb 10, 2026
Merged
use vue instance level 'provide/inject' mechanism for pinia store#26438rijkvanzanten merged 9 commits intodirectus:mainfrom
rijkvanzanten merged 9 commits intodirectus:mainfrom
Conversation
rijkvanzanten
requested changes
Feb 10, 2026
Member
rijkvanzanten
left a comment
rijkvanzanten
left a comment
There was a problem hiding this comment.
Thank you for this @kekekuli! Opened on my birthday no less 🍰
Couple of tiny nits, but this generally looks good to go to me
rijkvanzanten
approved these changes
Feb 10, 2026
Nitwel
approved these changes
Feb 10, 2026
Member
Nitwel
left a comment
Nitwel
left a comment
There was a problem hiding this comment.
Just confirmed this fixed the problem. Nice work!
Contributor
Author
Happy birthday for you! Thank you to review |
AlexGaillard
pushed a commit
that referenced
this pull request
Feb 18, 2026
…6438) * fix: use vue app level provide/inject (#26411) * changeset update * sort imports * Update .changeset/goofy-fans-bow.md * Update app/src/main.ts * Update .changeset/goofy-fans-bow.md * Update app/src/composables/use-system.ts --------- Co-authored-by: Nitwel <[email protected]> Co-authored-by: Rijk van Zanten <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
What's changed:
useSystemnow require one arg, the vue app instance, to ensure 'provide' is effect at vue app level, not component levelPotential Risks / Drawbacks
app.vue. Did I missed other callers?useSystemis not suitable as one composable, its name and source file path would bring mess I think, it's effect is more like 'initProvide' or 'registerContext' such like.Tested Scenarios
Review Notes / Questions
Checklist
Fixes #26411, #25410
By the way, as describe at #26411, it breaks for a long time. I belive it is ad5361a this commit bring out ( update vue from 3.4.xx to 3.5.xx, which introduce break changes), which means it seems to break 1 years.. I am a little suprised.
Edits: As a Amateur code sleuth, I use git to do time travel, It is exactly the ad5361a caused. After ad5361a, all attempts to call
useStorein extension source code will throw error. A impressive learning course Lol.