Fix: Markdown editor min-height alignment#26430
Merged
rijkvanzanten merged 5 commits intodirectus:mainfrom Jan 7, 2026
Merged
Conversation
DamnItAzriel
force-pushed
the
fix-md-editor-height
branch
from
2237f96 to
496fca3
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a visual glitch in the Markdown editor where the internal scroll area was not properly aligned with the enforced minimum height of the input container, causing an unwanted gap.
Key changes:
- Refactored CSS height variables from
--input-height-talland--input-height-maxto a more semantic naming scheme (--input-height-default,--input-height-large,--input-height-xlarge) - Implemented a calculation-based approach in the Markdown editor to properly align the CodeMirror scroll area with the container's minimum height by accounting for the toolbar height
- Updated all component references throughout the codebase to use the new variable names consistently
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
app/src/styles/_variables.scss |
Renamed and restructured input height CSS variables to use more semantic names (default/large/xlarge) |
app/src/interfaces/input-rich-text-md/input-rich-text-md.vue |
Fixed markdown editor layout by introducing calculated min-height for CodeMirror scroll area that accounts for toolbar height |
app/src/styles/lib/_codemirror.scss |
Updated global CodeMirror scroll min-height to use new --input-height-default variable |
app/src/views/private/components/folder-picker.vue |
Updated max-height calculation to use new variable name |
app/src/views/private/components/file-preview.vue |
Updated preview container height to use new variable name |
app/src/interfaces/select-multiple-checkbox-tree/select-multiple-checkbox-tree.vue |
Updated max-height to use new --input-height-xlarge variable |
app/src/interfaces/input-rich-text-html/input-rich-text-html.vue |
Updated image/media preview height to use new variable name |
app/src/interfaces/file-image/file-image.vue |
Updated image preview and placeholder heights to use new variable name |
app/src/interfaces/_system/system-theme-overrides/system-theme-overrides.vue |
Updated max-height to use new --input-height-xlarge variable |
app/src/components/v-upload.vue |
Updated dropzone min-height to use new variable name |
app/src/components/v-textarea.vue |
Updated textarea height to use new variable name |
app/src/components/v-template-input.vue |
Updated multiline input height to use new variable name |
app/src/components/v-skeleton-loader.vue |
Updated skeleton loader height to use new variable name |
app/src/components/v-form/components/form-field-raw-editor.vue |
Updated CodeMirror max-height to use new --input-height-xlarge variable |
.changeset/soft-tires-yawn.md |
Added changeset documenting the markdown editor layout fix |
rijkvanzanten
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
What's changed:
Potential Risks / Drawbacks
Tested Scenarios
Review Notes / Questions
Checklist
Fixes #26422