Access policies permissions improve select ux#26410
Merged
rijkvanzanten merged 10 commits intodirectus:mainfrom Jan 7, 2026
Merged
Access policies permissions improve select ux#26410rijkvanzanten merged 10 commits intodirectus:mainfrom
rijkvanzanten merged 10 commits intodirectus:mainfrom
Conversation
Contributor
Author
|
@licitdev Hi Ian, Thanh's here. could you help me check on this :D Thank you! |
licitdev
reviewed
Jan 2, 2026
Member
licitdev
left a comment
licitdev
left a comment
There was a problem hiding this comment.
@thanhle98 The improvement looks good! 👍 Could we also include unit tests for the changes? Thanks!
Co-authored-by: ian <[email protected]>
rijkvanzanten
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
What's changed:
Problem 1: User has to reopen the modal repeatedly when adding multiple collections
Fix: Keep modal open after each addition
Problem 2: Added collections disappear from list, causing a distracting reorder flash
Fix: Disable added items in dropdown instead of removing them
Potential Risks / Drawbacks
Tested Scenarios
Fixes #24241