Skip to content

Fix for search input issues on feat/ai #26331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rijkvanzanten merged 1 commit into from
Dec 8, 2025
Merged

Fix for search input issues on feat/ai #26331

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 42 additions & 2 deletions app/src/views/private/components/search-input.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,18 @@ function disable() {
input.value?.blur();
}

function onFocusOut(event: FocusEvent) {
if (filterActive.value) return;

// Check if focus is moving to another element inside the search component -- prevents race condition on touch vs click events
const searchElement = (event.currentTarget as HTMLElement)?.closest('.search-input');
const relatedTarget = event.relatedTarget as HTMLElement | null;

if (relatedTarget && searchElement?.contains(relatedTarget)) return;

disable();
}

function emitValue() {
if (!input.value) return;
const value = input.value?.value;
Expand All @@ -120,7 +132,14 @@ function emitValue() {
</script>

<template>
<v-badge bottom right class="search-badge" :value="activeFilterCount" :disabled="!activeFilterCount || filterActive">
<v-badge
bottom
right
class="search-badge"
:class="{ active, 'filter-active': filterActive }"
:value="activeFilterCount"
:disabled="!activeFilterCount || filterActive"
>
<div
v-click-outside="{
handler: disable,
Expand Down Expand Up @@ -153,7 +172,7 @@ function emitValue() {
@paste="emitValue"
@keydown.esc="disable"
@focusin="activate"
@focusout="filterActive ? undefined : disable()"
@focusout="onFocusOut"
/>
<div class="spacer" />
<v-icon
Expand Down Expand Up @@ -196,6 +215,20 @@ function emitValue() {
--v-badge-background-color: var(--theme--primary);
--v-badge-offset-y: 8px;
--v-badge-offset-x: 8px;

@media (width <= 400px) {
&.active,
&.filter-active {
position: absolute;
inset-inline: 0;
z-index: 1;
background-color: var(--theme--header--background);
}
}

:deep(.badge) {
pointer-events: none;
}
}

.search-input {
Expand Down Expand Up @@ -378,6 +411,13 @@ function emitValue() {
border-end-end-radius: var(--search-input-radius);
border-end-start-radius: var(--search-input-radius);

@media (width <= 400px) {
inset-inline: 0;
inline-size: calc(100% + var(--theme--border-width) * 2);
min-inline-size: 0;
border-start-start-radius: 0;
}

&.active {
border-color: var(--theme--form--field--input--border-color-focus);
}
Expand Down