Skip to content

Revert "Add multi-domain OAuth/OpenID support (#26074)"#26239

Merged
AlexGaillard merged 3 commits intomainfrom
revert-sso-multi-domain
Nov 21, 2025
Merged

Revert "Add multi-domain OAuth/OpenID support (#26074)"#26239
AlexGaillard merged 3 commits intomainfrom
revert-sso-multi-domain

Conversation

@ComfortablyCoding
Copy link
Member

@ComfortablyCoding ComfortablyCoding commented Nov 21, 2025

Scope

What's changed:

Reverted #26074 as these changes did not account for:

  • A studio hosted on a different domain as the API
  • A frontend redirecting to this OAuth flow
  • A PUBLIC_URL with a subpath

The first 2 do not have an optimal solution at this time, reverting in the interest of resolving these regressions while we research alternate paths.

Potential Risks / Drawbacks

  • Lorem ipsum dolor sit amet
  • Consectetur adipiscing elit

Tested Scenarios

  • Lorem ipsum dolor sit amet
  • Consectetur adipiscing elit

Review Notes / Questions

  • I would like to lorem ipsum
  • Special attention should be paid to dolor sit amet

Checklist

  • Added or updated tests
  • Documentation PR created here or not required
  • OpenAPI package PR created here or not required

Fixes #26236
Fixes #26237
Re-opens: #25404

@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

❌ Patch coverage is 22.44898% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.11%. Comparing base (15276cd) to head (b15343c).
⚠️ Report is 2 commits behind head on main.

❌ Your patch status has failed because the patch coverage (22.44%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #26239      +/-   ##
==========================================
- Coverage   59.57%   59.11%   -0.46%     
==========================================
  Files        2080     2079       -1     
  Lines      131587   131573      -14     
  Branches     8029     7905     -124     
==========================================
- Hits        78394    77782     -612     
- Misses      53193    53791     +598     
Flag Coverage Δ
api 43.39% <22.44%> (-1.12%) ⬇️
app 70.36% <ø> (-0.15%) ⬇️
composables 82.25% <ø> (ø)
create-directus-extension 94.44% <ø> (ø)
create-directus-project 98.43% <ø> (ø)
env 99.67% <ø> (ø)
errors 97.47% <ø> (ø)
extensions 35.63% <ø> (ø)
extensions-registry 95.27% <ø> (ø)
extensions-sdk 14.38% <ø> (ø)
format-title 100.00% <ø> (ø)
memory 95.75% <ø> (ø)
pressure 77.63% <ø> (ø)
release-notes-generator 81.14% <ø> (ø)
schema-builder 80.59% <ø> (ø)
sdk 8.33% <ø> (ø)
storage 92.00% <ø> (ø)
storage-driver-azure 76.76% <ø> (ø)
storage-driver-cloudinary 81.14% <ø> (ø)
storage-driver-gcs 69.72% <ø> (ø)
storage-driver-local 69.76% <ø> (ø)
storage-driver-s3 46.73% <ø> (ø)
storage-driver-supabase 68.20% <ø> (ø)
system-data 71.81% <ø> (ø)
update-check 55.67% <ø> (ø)
utils 87.16% <ø> (ø)
validation 44.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AlexGaillard AlexGaillard merged commit 0842968 into main Nov 21, 2025
65 of 68 checks passed
@AlexGaillard AlexGaillard deleted the revert-sso-multi-domain branch November 21, 2025 14:01
@github-actions github-actions bot added this to the Next Release milestone Nov 21, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SSO Broken in 11.13 SSO Login Not Sending Public_URL

2 participants