Ensure that flows open in a new tab by pressing Ctrl/Cmd+click or the middle mouse button#26181
Merged
AlexGaillard merged 7 commits intodirectus:mainfrom Nov 20, 2025
Merged
Conversation
…dle mouse button Fixes directus#26103 - Updated navigateToFlow function to accept event parameter - Added support for Ctrl+Click, Cmd+Click, and middle mouse button - Opens flows in new tab using window.open() when modifier keys are pressed - Added comprehensive tests for all click scenarios - Maintains backward compatibility with normal clicks
0839037 to
8d55d85
Compare
formfcw
requested changes
Nov 20, 2025
Contributor
formfcw
left a comment
There was a problem hiding this comment.
Hey @dstockton 👋, you beat me to it. The copilot suggestion doesn’t make sense …
Co-authored-by: Florian C. Wachmann <[email protected]>
Contributor
Author
Thanks for the message & manual review :) |
formfcw
approved these changes
Nov 20, 2025
Contributor
There was a problem hiding this comment.
Thank you so much @dstockton ❤️ for your first contribution 🚀
Perfect, thank you for adding a test.
Nice improvement!
LGTM 🎉
Contributor
Author
@formfcw - thanks - even though I've added a test, codecov isn't happy about the "reduced" coverage level. Is that something I need to solve (by adding even more tests) before this is mergeable? Or would you just merge anyway? |
Contributor
|
It’s fine in this case! |
dletterio1
pushed a commit
to dletterio1/directus
that referenced
this pull request
Jan 12, 2026
… middle mouse button (directus#26181)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
What's changed:
Tested Scenarios
Review Notes / Questions
Checklist
Fixes #26103