Skip to content

Ensure that flows open in a new tab by pressing Ctrl/Cmd+click or the middle mouse button#26181

Merged
AlexGaillard merged 7 commits intodirectus:mainfrom
dstockton:fix/flows-open-in-new-tab
Nov 20, 2025
Merged

Ensure that flows open in a new tab by pressing Ctrl/Cmd+click or the middle mouse button#26181
AlexGaillard merged 7 commits intodirectus:mainfrom
dstockton:fix/flows-open-in-new-tab

Conversation

@dstockton
Copy link
Contributor

Scope

What's changed:

  • Updated navigateToFlow function to accept event parameter
  • Added support for Ctrl+Click, Cmd+Click, and middle mouse button
  • Opens flows in new tab using window.open() when modifier keys are pressed
  • Added comprehensive tests for all click scenarios
  • Maintains backward compatibility with normal clicks

Tested Scenarios

  • Added test coverage for:
    • normal mouse click
    • ctrl + mouse click
    • cmd + mouse click
    • middle mouse click

Review Notes / Questions

  • Is the test code structure matching maintainer expectations?

Checklist

  • Added or updated tests
  • Documentation PR created here or not required
  • OpenAPI package PR created here or not required

Fixes #26103

…dle mouse button

Fixes directus#26103

- Updated navigateToFlow function to accept event parameter
- Added support for Ctrl+Click, Cmd+Click, and middle mouse button
- Opens flows in new tab using window.open() when modifier keys are pressed
- Added comprehensive tests for all click scenarios
- Maintains backward compatibility with normal clicks
@dstockton dstockton force-pushed the fix/flows-open-in-new-tab branch from 0839037 to 8d55d85 Compare November 13, 2025 23:59
@formfcw formfcw requested review from Copilot and formfcw November 20, 2025 12:25
@formfcw formfcw changed the title fix(flows): allow opening flows in new tab with Ctrl/Cmd+Click or middle mouse button Ensure that flows open in a new tab by pressing Ctrl/Cmd+click or the middle mouse button Nov 20, 2025

This comment was marked as resolved.

Copy link
Contributor

@formfcw formfcw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dstockton 👋, you beat me to it. The copilot suggestion doesn’t make sense …

@dstockton
Copy link
Contributor Author

Hey @dstockton 👋, you beat me to it. The copilot suggestion doesn’t make sense …

Thanks for the message & manual review :)

Copy link
Contributor

@formfcw formfcw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @dstockton ❤️ for your first contribution 🚀
Perfect, thank you for adding a test.
Nice improvement!

LGTM 🎉

@dstockton
Copy link
Contributor Author

@formfcw - thanks - even though I've added a test, codecov isn't happy about the "reduced" coverage level. Is that something I need to solve (by adding even more tests) before this is mergeable? Or would you just merge anyway?

@formfcw
Copy link
Contributor

formfcw commented Nov 20, 2025

It’s fine in this case!

Copy link
Member

@AlexGaillard AlexGaillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆒🫘

@AlexGaillard AlexGaillard merged commit d5bc1f5 into directus:main Nov 20, 2025
64 of 65 checks passed
@github-actions github-actions bot added this to the Next Release milestone Nov 20, 2025
@dstockton dstockton deleted the fix/flows-open-in-new-tab branch November 20, 2025 15:16
dletterio1 pushed a commit to dletterio1/directus that referenced this pull request Jan 12, 2026
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flows Page: Cannot Open Flows in a New tab

4 participants