Skip to content

Comparison ← fix reactivity issue#26083

Merged
robluton merged 1 commit intorobl/cms-1246-content-comparison-modal-corefrom
florian/comparison-fix-reactivity
Oct 31, 2025
Merged

Comparison ← fix reactivity issue#26083
robluton merged 1 commit intorobl/cms-1246-content-comparison-modal-corefrom
florian/comparison-fix-reactivity

Conversation

@formfcw
Copy link
Contributor

@formfcw formfcw commented Oct 31, 2025

Scope

What's changed:

  • fixed reactivity issue by changing currentRevision from prop to model

Bug reproduction:

  • create an item, make edits, save
  • update the item so you have two revision entries: Revision A and Revision B
  • Open Revision A in the modal
  • Inside the modal use the dropdown to switch to Revision B and close the modal
  • Open Revision A again …

… the modal shows Revision B instead of A.

@formfcw formfcw requested a review from robluton October 31, 2025 08:26
@formfcw formfcw marked this pull request as ready for review October 31, 2025 08:27
@formfcw formfcw requested a review from a team as a code owner October 31, 2025 08:27
@formfcw formfcw removed the request for review from a team October 31, 2025 08:27
Copy link
Contributor

@robluton robluton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎶

@robluton robluton merged commit cc793ce into robl/cms-1246-content-comparison-modal-core Oct 31, 2025
1 check passed
@robluton robluton deleted the florian/comparison-fix-reactivity branch October 31, 2025 13:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants