Add tracking of `mcp_enabled`, `mcp_allow_deletes`, `mcp_system_prompt_enabled` and `visual_editor_urls` in telemetry reports by connorwinston · Pull Request #25989 · directus/directus

connorwinston · 2025-10-17T02:00:41Z

What's changed:

Include MCP Telemetry in Telemetry
Include Additional Settings in Telemetry

Potential Risks / Drawbacks

N/a

Tested Scenarios

Updated Tests for New Functions and Reported Data

Review Notes / Questions

N/a

Checklist

Update Internal Telemetry Systems for New Schema

linear · 2025-10-17T02:00:45Z

PM-968 Telemetry to inform MCP usage

Copilot

Pull Request Overview

Adds telemetry collection for additional project settings, replacing the previous standalone project_id fetch with a consolidated settings query.

Introduces getSettings utility returning project_id plus multiple MCP and visual editor related metrics
Updates TelemetryReport interface to require project_id and include new settings fields
Replaces getProjectId usage with getSettings throughout code and adjusts tests and changeset

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
api/src/telemetry/utils/get-settings.ts	New utility fetching project settings and deriving telemetry metrics
api/src/telemetry/utils/get-settings.test.ts	Tests for new getSettings utility (normal and partial data cases)
api/src/telemetry/utils/get-project-id.ts	Removed obsolete project_id-only utility
api/src/telemetry/utils/get-project-id.test.ts	Removed tests for deprecated getProjectId
api/src/telemetry/types/report.ts	TelemetryReport updated to require project_id and add new settings fields
api/src/telemetry/lib/get-report.ts	Swapped getProjectId for getSettings and spreads settings into report
api/src/telemetry/lib/get-report.test.ts	Adjusted tests to mock and validate settings inclusion
.changeset/wet-weeks-buy.md	Version bump (minor) and description of added telemetry metrics

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

api/src/telemetry/utils/get-settings.ts

api/src/telemetry/types/report.ts

Nitwel

Changes generally look good to me. I'm more interested how we are planning to make use of that information and why we would need to track so many different MCP options specifically as I'd like to keep telemetry collection to a reasonable and minimal amount if possible.

We already track the public_url so tracking the visual_editor_urls feels quite invasive to me.

And you don't really need to track accepted_terms as that field will be replaced soon anyways by the product_owner field in the KYC project.

.changeset/wet-weeks-buy.md

connorwinston · 2025-10-17T19:34:28Z

We already track the public_url so tracking the visual_editor_urls feels quite invasive to me.

This only tracks the count of how many are configured, so we know if the feature is being used. It does not track the actual URLs.

JamesW1 · 2025-10-20T17:46:43Z

Just to echo @connorwinston points - we are not intending to capture visual editor URLs, it's just a numerical flag to inform us on whether this feature is being used (number > 0).

Equally, the MCP booleans help us understand if they are using defaults or customized, but no specific details.

Nitwel · 2025-10-21T10:12:21Z

Got it, got a bit mislead by the name of the variable and overlooked the fact that it mapped to a number.

api/src/telemetry/types/report.ts

Co-authored-by: Nitwel <[email protected]>

…-usage

…ttps://github.com/directus/directus into connorwinston/pm-968-telemetry-to-inform-mcp-usage

…-usage

Resolved

connorwinston added 3 commits October 16, 2025 11:30

Add Additional Settings/Metrics to Telemetry

3fa4a20

Changeset

0ec60ac

Fix Tests

cd10230

connorwinston self-assigned this Oct 17, 2025

connorwinston requested a review from a team as a code owner October 17, 2025 02:00

connorwinston added the Improvement label Oct 17, 2025

connorwinston requested review from Copilot and licitdev October 17, 2025 02:00

Copilot AI reviewed Oct 17, 2025

View reviewed changes

api/src/telemetry/utils/get-settings.ts Show resolved Hide resolved

api/src/telemetry/utils/get-settings.ts Show resolved Hide resolved

api/src/telemetry/types/report.ts Show resolved Hide resolved

Nitwel previously requested changes Oct 17, 2025

View reviewed changes

.changeset/wet-weeks-buy.md Outdated Show resolved Hide resolved

licitdev assigned licitdev and unassigned connorwinston Oct 24, 2025

licitdev reviewed Oct 24, 2025

View reviewed changes

api/src/telemetry/types/report.ts Outdated Show resolved Hide resolved

connorwinston and others added 3 commits October 24, 2025 10:29

Remove Acepted Terms

4459fef

Update .changeset/wet-weeks-buy.md

9b033e7

Co-authored-by: Nitwel <[email protected]>

Update Changeset

bc61cd0

connorwinston requested a review from licitdev October 24, 2025 15:30

connorwinston and others added 5 commits October 24, 2025 10:30

Merge branch 'main' into connorwinston/pm-968-telemetry-to-inform-mcp…

848ab1e

…-usage

Fix Formatting

24027ff

Merge branch 'connorwinston/pm-968-telemetry-to-inform-mcp-usage' of h…

6b6e45e

…ttps://github.com/directus/directus into connorwinston/pm-968-telemetry-to-inform-mcp-usage

Merge branch 'main' into connorwinston/pm-968-telemetry-to-inform-mcp…

615651e

…-usage

Organize imports

7965f06

licitdev approved these changes Oct 27, 2025

View reviewed changes

licitdev changed the title ~~Update Telemetry~~ Add tracking of mcp_enabled, mcp_allow_deletes, mcp_system_prompt_enabled and visual_editor_urls in telemetry reports Oct 27, 2025

licitdev merged commit c135ddf into main Oct 27, 2025
66 checks passed

licitdev deleted the connorwinston/pm-968-telemetry-to-inform-mcp-usage branch October 27, 2025 10:29

github-actions bot added this to the Next Release milestone Oct 27, 2025

github-actions bot locked as resolved and limited conversation to collaborators Dec 27, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add tracking of `mcp_enabled`, `mcp_allow_deletes`, `mcp_system_prompt_enabled` and `visual_editor_urls` in telemetry reports#25989

Add tracking of `mcp_enabled`, `mcp_allow_deletes`, `mcp_system_prompt_enabled` and `visual_editor_urls` in telemetry reports#25989
licitdev merged 11 commits intomainfrom
connorwinston/pm-968-telemetry-to-inform-mcp-usage

connorwinston commented Oct 17, 2025 •

edited by licitdev

Loading

Uh oh!

linear bot commented Oct 17, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Nitwel left a comment

Uh oh!

Uh oh!

connorwinston commented Oct 17, 2025

Uh oh!

JamesW1 commented Oct 20, 2025 •

edited

Loading

Uh oh!

Nitwel commented Oct 21, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

connorwinston commented Oct 17, 2025 • edited by licitdev Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Potential Risks / Drawbacks

Tested Scenarios

Review Notes / Questions

Checklist

Uh oh!

linear bot commented Oct 17, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Nitwel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

connorwinston commented Oct 17, 2025

Uh oh!

JamesW1 commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Nitwel commented Oct 21, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

connorwinston commented Oct 17, 2025 •

edited by licitdev

Loading

JamesW1 commented Oct 20, 2025 •

edited

Loading