Fix skipping properties with undefined value in SDK query parsing#25952
Merged
ComfortablyCoding merged 24 commits intomainfrom Oct 10, 2025
Conversation
Co-authored-by: daedalus <[email protected]>
Co-authored-by: daedalus <[email protected]>
Co-authored-by: daedalus <[email protected]>
Co-authored-by: daedalus <[email protected]>
Co-authored-by: daedalus <[email protected]>
…ean and number types because they result in the same string as the String constructor
…the old implementation when using strings
ComfortablyCoding
requested changes
Oct 9, 2025
Member
ComfortablyCoding
left a comment
There was a problem hiding this comment.
Tests for version and versionRaw are missing but otherwise LGTM 🚀
br41nslug
commented
Oct 10, 2025
undefined value in SDK query parsing
ComfortablyCoding
approved these changes
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
What's changed:
search: undefinedactually searching for the string'undefined'(linked issue)undefinedhandling for the other query parametersformatFieldsandqueryToParamsutilitiesaggregatetype by addingPartial(the tests showed that all aggregation keys were required before)aggregatetype by adding& Record<string, unknown>allowing for custom properties without type errorsrequest.test.tsfile next to therequest.tsfile (to consistently keep functional test files next to the file they're testing and type tests in thetest/folder)Potential Risks / Drawbacks
Tested Scenarios
Review Notes / Questions
Checklist
Fixes #25930