Open
Conversation
u12206050
force-pushed
the
imp/improved-db-queries
branch
from
b1ce469 to
dc2020d
Compare
2 tasks
If have to join, use info about schema to determine using inner vs left join
u12206050
force-pushed
the
imp/improved-db-queries
branch
from
dc2020d to
1186abf
Compare
Contributor
|
Thanks for your contributions, I'm closing this stale PR. If you believe that's in error and the PR is passing tests, ready for review, please do re-open. |
Contributor
Author
|
Last I checked it was passing tests and was ready for review. I am Has been working flawlessly in production for us the past 4months. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
What's changed:
The sql being generated is focused on using operations the DB can optimise instead of LEFT JOINS, which the DB just can't optimise as good.
Potential Risks / Drawbacks
SELECT *won't select the fields on the related collections, but since Directus does either specify exactly the fields, or fetches related items in a separate request, most users won't notice this except for the improved performance.Tested Scenarios
Review Notes / Questions
Checklist
Fixes #25861