Extensions-sdk: Fix bundling of deps with node conditional exports by julbd · Pull Request #25591 · directus/directus

julbd · 2025-08-04T14:25:53Z

Scope

Packages can define conditional exports for specific environments. When building App extensions, @directus/extensions-sdk correctly handle the "browser" exports, but it ignores the "node" for Api extensions and fails to build (like with execa). @rijkvanzanten

Change : Prefer dependencies' "node" conditional exports when building API extensions

Some api extensions that (wrongly) use the default conditional exports of their dependencies could fail to build after this change.
They can enforce the old-but-invalid behavior with :

    plugins: [
        nodeResolve({ exportConditions: [] })
    ]

Checklist

No tests added
No documentation update required

changeset-bot · 2025-08-04T14:25:57Z

⚠️ No Changeset found

Latest commit: e4c4c1d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

codecov · 2025-08-04T14:38:49Z

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.57%. Comparing base (006d171) to head (6a80626).
⚠️ Report is 1 commits behind head on main.

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #25591      +/-   ##
==========================================
- Coverage   57.57%   57.57%   -0.01%     
==========================================
  Files        2041     2041              
  Lines      128885   128889       +4     
  Branches     6942     6942              
==========================================
  Hits        74205    74205              
- Misses      54680    54684       +4

Flag	Coverage Δ
api	`38.82% <ø> (ø)`
app	`70.38% <ø> (ø)`
composables	`82.80% <ø> (ø)`
create-directus-extension	`94.44% <ø> (ø)`
create-directus-project	`98.43% <ø> (ø)`
env	`99.66% <ø> (ø)`
errors	`97.31% <ø> (ø)`
extensions	`35.63% <ø> (ø)`
extensions-registry	`95.27% <ø> (ø)`
extensions-sdk	`14.38% <0.00%> (-0.03%)`	⬇️
format-title	`100.00% <ø> (ø)`
memory	`95.75% <ø> (ø)`
pressure	`77.63% <ø> (ø)`
release-notes-generator	`81.14% <ø> (ø)`
schema-builder	`80.56% <ø> (ø)`
sdk	`8.33% <ø> (ø)`
storage	`92.00% <ø> (ø)`
storage-driver-azure	`76.76% <ø> (ø)`
storage-driver-cloudinary	`81.14% <ø> (ø)`
storage-driver-gcs	`69.72% <ø> (ø)`
storage-driver-local	`69.76% <ø> (ø)`
storage-driver-s3	`46.73% <ø> (ø)`
storage-driver-supabase	`68.20% <ø> (ø)`
update-check	`55.67% <ø> (ø)`
utils	`87.16% <ø> (ø)`
validation	`44.50% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

julbd · 2025-08-04T16:20:35Z

Additionally, I'd suggest to support providing a function in extension.config.*, allowing the user to customize the configuration for each extension of a bundle. Something like :

// extension.config.js

export default ({ mode, input, sourcemap, minify }) => ({
    plugins: [
        mode === 'browser' ? barPlugin() : fooPlugin(),
        ...
    ]
})

Nitwel

Great fix, thank you for the contribution! ❤️

Fix bundling of deps with node conditional exports

e27f633

Update contributors.yml

e611fb5

Format build.ts

e4c4c1d

add changeset

49613de

Nitwel requested a review from a team as a code owner October 21, 2025 10:59

Merge remote-tracking branch 'origin/main' into patch-3

6a80626

Nitwel approved these changes Oct 21, 2025

View reviewed changes

Nitwel merged commit 4461249 into directus:main Oct 21, 2025
61 of 63 checks passed

github-actions bot added this to the Next Release milestone Oct 21, 2025

github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Extensions-sdk: Fix bundling of deps with node conditional exports#25591

Extensions-sdk: Fix bundling of deps with node conditional exports#25591
Nitwel merged 5 commits intodirectus:mainfrom
julbd:patch-3

julbd commented Aug 4, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented Aug 4, 2025 •

edited

Loading

Uh oh!

codecov bot commented Aug 4, 2025 •

edited

Loading

Uh oh!

julbd commented Aug 4, 2025 •

edited

Loading

Uh oh!

Nitwel left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

julbd commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Scope

Potential Risks / Drawbacks

Checklist

Uh oh!

changeset-bot bot commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

codecov bot commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

julbd commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Nitwel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

julbd commented Aug 4, 2025 •

edited

Loading

changeset-bot bot commented Aug 4, 2025 •

edited

Loading

codecov bot commented Aug 4, 2025 •

edited

Loading

julbd commented Aug 4, 2025 •

edited

Loading