Skip to content

Add a connect timeout option to the sdk realtime options#25349

Merged
gaetansenn merged 7 commits intomainfrom
issue-25310
Oct 3, 2025
Merged

Add a connect timeout option to the sdk realtime options#25349
gaetansenn merged 7 commits intomainfrom
issue-25310

Conversation

@ComfortablyCoding
Copy link
Member

@ComfortablyCoding ComfortablyCoding commented Jun 24, 2025

Scope

What's changed:

  • A configurable timeout is now set for realtime connection requests to prevent infinite connection hangs
  • Tiny refactor to use reject instead of new Error when throwing an error inside the promise constructor

Potential Risks / Drawbacks

  • N/A

Review Notes / Questions

  • Doc PR pending review

Fixes #25310

@ComfortablyCoding ComfortablyCoding requested a review from a team as a code owner June 24, 2025 15:36
@changeset-bot
Copy link

changeset-bot bot commented Jun 24, 2025

🦋 Changeset detected

Latest commit: 4adc75c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@directus/sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ComfortablyCoding ComfortablyCoding changed the title Add connection timeout to sdk realtime Add a connect timeout option to the sdk realtime configuration options Jun 24, 2025
@ComfortablyCoding ComfortablyCoding changed the title Add a connect timeout option to the sdk realtime configuration options Add a connect timeout option to the sdk realtime options Jun 25, 2025
@gaetansenn gaetansenn requested a review from a team as a code owner October 3, 2025 10:37
@gaetansenn gaetansenn merged commit 68942ab into main Oct 3, 2025
64 of 66 checks passed
@gaetansenn gaetansenn deleted the issue-25310 branch October 3, 2025 14:06
@gaetansenn
Copy link
Contributor

LGTM 🚀

@github-actions github-actions bot added this to the Next Release milestone Oct 3, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Websocket Reconnect Failure

2 participants