ENG-1289 CockroachDB migrations stuck in infinite loop without SKIP_MIGRATIONS=true

🦋 Changeset detected

Latest commit: f53cd99

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Is this native primary key approach backwards compatible with the existing v23 an v24 LTS versions?

We'll figure that out by seeing if Backbox tests pass but I'd guess so, let me check...

From what I can see, it's likely been introduced in v20 as it doesn't exist in the docs previous to that: https://www.cockroachlabs.com/docs/v20.1/alter-primary-key.html

We'll figure that out by seeing if Backbox tests pass but I'd guess so, let me check...

The blackbox tests do not run for CRDB https://github.com/directus/directus/blob/main/.github/workflows/blackbox.yml#L56

Should include it now but I guess I better check manually as well if it worked with older versions.

Codecov Report

❌ Patch coverage is 22.22222% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.26%. Comparing base (6c3e76f) to head (f53cd99).
⚠️ Report is 192 commits behind head on main.

❌ Your patch status has failed because the patch coverage (22.22%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

@@            Coverage Diff             @@
##             main   #25280      +/-   ##
==========================================
- Coverage   56.26%   56.26%   -0.01%     
==========================================
  Files        2001     2001              
  Lines      125055   125069      +14     
  Branches     6308     6308              
==========================================
+ Hits        70367    70371       +4     
- Misses      54688    54698      +10     

This is deeply stale. Going to close this one out and keep the branch if we ever want to revisit it.