Use transaction in down migration for comments#23715
Merged
rijkvanzanten merged 1 commit intoretentions-p1from Sep 26, 2024
Merged
Use transaction in down migration for comments#23715rijkvanzanten merged 1 commit intoretentions-p1from
rijkvanzanten merged 1 commit intoretentions-p1from
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
rijkvanzanten
approved these changes
Sep 26, 2024
ComfortablyCoding
added a commit
that referenced
this pull request
Oct 16, 2024
* Extract comments to a separate table (#22295) * Add directus_comments migration * Add comments controller and service * Remove from activity * Update system-data and types * Refactor app with new endpoints * Expose service * Update app minimal permissions * Add collection translation * Define relations * Allow comment creation only if there's item read access * Patch for MSSQL double constraints issue * Fix users service test * Add sdk support * Update specs * Fix formatting * Fix specs error * Patch whoopsie * Remove obsolete GraphQL mutations * Update required fields * Remove unused vars * Allow edit and delete of legacy activity comments * Remove legacy comments from SDK * Add changeset * Batch upwards migration * Update SDK to use keysOrQuery Co-authored-by: Brainslug <[email protected]> * Update implementation for keysOrQuery * Remove singleton check * Update SDK to use keysOrQuery 2 Co-authored-by: Brainslug <[email protected]> * Update keysOrQuery typedoc * Fix import * Update migration timestamp * fixed import * Update api/src/utils/get-service.ts * utilize chunk processing in migration * formatting * only services extended from itemservice should be added * remove redundant checks from comment header * update comment service to v11 permission format * specify missing required fields * Mock comments in users test * Simplify migration and update date * WIP legacy access * Optimise imports * WIP app cleanup * Update loadUserPreviews typing Co-authored-by: Daniel Biegler <[email protected]> * Read legacy comments * Parse using comments service * Perform migration directly * Fix legacy app sort query which uses id * Migrate legacy comments in mutations * Reduce api semver * Update app recommended permissions * Recommend updating of comment only * replace hardcoded type with existing one * Allow users to update or delete their own comments Co-authored-by: daedalus <[email protected]> * Skip further access validation for non-existent collections * Check if collection exists before the admin check Co-authored-by: daedalus <[email protected]> * Fix incorrect legacy check Co-authored-by: Daniel Biegler <[email protected]> * Fix merging of count when db returns count as string type * Remove unused import --------- Co-authored-by: Brainslug <[email protected]> Co-authored-by: Pascal Jufer <[email protected]> Co-authored-by: Brainslug <[email protected]> Co-authored-by: daedalus <[email protected]> Co-authored-by: Daniel Biegler <[email protected]> * Consolidate content versioning (#22413) * Add migration * Use the new delta field * Add cast-json flag * Fix typing * Fetch existing deltas if version created during migration * Add changeset * Add version delta field into sdk schema * Update migration timestamp * Update versions.save() to return finalVersionDelta Co-authored-by: Pascal Jufer <[email protected]> * Sort on DB level * Update migration date * Disallow passing delta via create/update * Update docs & specs * Fix save response * Remove unnecessary access check Already checked by the subsequent itemsService.readOne call * Update changeset * Don't require update perms on versions for save * Optimize validateCreateData * update to new validateAccess * Update docs/reference/system/versions.md * Remove migration of delta * Rename to legacy * Add missed changes for Remove migration of delta in 2e2f50f * Update docs/reference/system/versions.md --------- Co-authored-by: Pascal Jufer <[email protected]> Co-authored-by: daedalus <[email protected]> * Update migration dates * api change should be major for versioning * Remove comment paths from activity reference * Added comments reference * Added directus_comments to table of system collections * The linter demands newline * Revert function renaming for patch semver * Use transaction in down migration for comments (#23715) --------- Co-authored-by: Brainslug <[email protected]> Co-authored-by: Pascal Jufer <[email protected]> Co-authored-by: Brainslug <[email protected]> Co-authored-by: daedalus <[email protected]> Co-authored-by: Daniel Biegler <[email protected]> Co-authored-by: Kevin Lewis <[email protected]> Co-authored-by: Rijk van Zanten <[email protected]>
DanielBiegler
added a commit
that referenced
this pull request
Nov 18, 2024
* Extract comments to a separate table (#22295) * Add directus_comments migration * Add comments controller and service * Remove from activity * Update system-data and types * Refactor app with new endpoints * Expose service * Update app minimal permissions * Add collection translation * Define relations * Allow comment creation only if there's item read access * Patch for MSSQL double constraints issue * Fix users service test * Add sdk support * Update specs * Fix formatting * Fix specs error * Patch whoopsie * Remove obsolete GraphQL mutations * Update required fields * Remove unused vars * Allow edit and delete of legacy activity comments * Remove legacy comments from SDK * Add changeset * Batch upwards migration * Update SDK to use keysOrQuery Co-authored-by: Brainslug <[email protected]> * Update implementation for keysOrQuery * Remove singleton check * Update SDK to use keysOrQuery 2 Co-authored-by: Brainslug <[email protected]> * Update keysOrQuery typedoc * Fix import * Update migration timestamp * fixed import * Update api/src/utils/get-service.ts * utilize chunk processing in migration * formatting * only services extended from itemservice should be added * remove redundant checks from comment header * update comment service to v11 permission format * specify missing required fields * Mock comments in users test * Simplify migration and update date * WIP legacy access * Optimise imports * WIP app cleanup * Update loadUserPreviews typing Co-authored-by: Daniel Biegler <[email protected]> * Read legacy comments * Parse using comments service * Perform migration directly * Fix legacy app sort query which uses id * Migrate legacy comments in mutations * Reduce api semver * Update app recommended permissions * Recommend updating of comment only * replace hardcoded type with existing one * Allow users to update or delete their own comments Co-authored-by: daedalus <[email protected]> * Skip further access validation for non-existent collections * Check if collection exists before the admin check Co-authored-by: daedalus <[email protected]> * Fix incorrect legacy check Co-authored-by: Daniel Biegler <[email protected]> * Fix merging of count when db returns count as string type * Remove unused import --------- Co-authored-by: Brainslug <[email protected]> Co-authored-by: Pascal Jufer <[email protected]> Co-authored-by: Brainslug <[email protected]> Co-authored-by: daedalus <[email protected]> Co-authored-by: Daniel Biegler <[email protected]> * Consolidate content versioning (#22413) * Add migration * Use the new delta field * Add cast-json flag * Fix typing * Fetch existing deltas if version created during migration * Add changeset * Add version delta field into sdk schema * Update migration timestamp * Update versions.save() to return finalVersionDelta Co-authored-by: Pascal Jufer <[email protected]> * Sort on DB level * Update migration date * Disallow passing delta via create/update * Update docs & specs * Fix save response * Remove unnecessary access check Already checked by the subsequent itemsService.readOne call * Update changeset * Don't require update perms on versions for save * Optimize validateCreateData * update to new validateAccess * Update docs/reference/system/versions.md * Remove migration of delta * Rename to legacy * Add missed changes for Remove migration of delta in 2e2f50f * Update docs/reference/system/versions.md --------- Co-authored-by: Pascal Jufer <[email protected]> Co-authored-by: daedalus <[email protected]> * Update migration dates * api change should be major for versioning * Remove comment paths from activity reference * Added comments reference * Added directus_comments to table of system collections * The linter demands newline * Revert function renaming for patch semver * Use transaction in down migration for comments (#23715) * Remove outdated logic for versioning * Fix migration * Update api/src/database/migrations/20240924B-populate-versioning-deltas.ts * add changeset * reword changeset --------- Co-authored-by: Brainslug <[email protected]> Co-authored-by: Pascal Jufer <[email protected]> Co-authored-by: Brainslug <[email protected]> Co-authored-by: daedalus <[email protected]> Co-authored-by: Daniel Biegler <[email protected]> Co-authored-by: Kevin Lewis <[email protected]> Co-authored-by: Rijk van Zanten <[email protected]>
DanielBiegler
added a commit
that referenced
this pull request
Nov 19, 2024
* Extract comments to a separate table (#22295) * Add directus_comments migration * Add comments controller and service * Remove from activity * Update system-data and types * Refactor app with new endpoints * Expose service * Update app minimal permissions * Add collection translation * Define relations * Allow comment creation only if there's item read access * Patch for MSSQL double constraints issue * Fix users service test * Add sdk support * Update specs * Fix formatting * Fix specs error * Patch whoopsie * Remove obsolete GraphQL mutations * Update required fields * Remove unused vars * Allow edit and delete of legacy activity comments * Remove legacy comments from SDK * Add changeset * Batch upwards migration * Update SDK to use keysOrQuery Co-authored-by: Brainslug <[email protected]> * Update implementation for keysOrQuery * Remove singleton check * Update SDK to use keysOrQuery 2 Co-authored-by: Brainslug <[email protected]> * Update keysOrQuery typedoc * Fix import * Update migration timestamp * fixed import * Update api/src/utils/get-service.ts * utilize chunk processing in migration * formatting * only services extended from itemservice should be added * remove redundant checks from comment header * update comment service to v11 permission format * specify missing required fields * Mock comments in users test * Simplify migration and update date * WIP legacy access * Optimise imports * WIP app cleanup * Update loadUserPreviews typing Co-authored-by: Daniel Biegler <[email protected]> * Read legacy comments * Parse using comments service * Perform migration directly * Fix legacy app sort query which uses id * Migrate legacy comments in mutations * Reduce api semver * Update app recommended permissions * Recommend updating of comment only * replace hardcoded type with existing one * Allow users to update or delete their own comments Co-authored-by: daedalus <[email protected]> * Skip further access validation for non-existent collections * Check if collection exists before the admin check Co-authored-by: daedalus <[email protected]> * Fix incorrect legacy check Co-authored-by: Daniel Biegler <[email protected]> * Fix merging of count when db returns count as string type * Remove unused import --------- Co-authored-by: Brainslug <[email protected]> Co-authored-by: Pascal Jufer <[email protected]> Co-authored-by: Brainslug <[email protected]> Co-authored-by: daedalus <[email protected]> Co-authored-by: Daniel Biegler <[email protected]> * Consolidate content versioning (#22413) * Add migration * Use the new delta field * Add cast-json flag * Fix typing * Fetch existing deltas if version created during migration * Add changeset * Add version delta field into sdk schema * Update migration timestamp * Update versions.save() to return finalVersionDelta Co-authored-by: Pascal Jufer <[email protected]> * Sort on DB level * Update migration date * Disallow passing delta via create/update * Update docs & specs * Fix save response * Remove unnecessary access check Already checked by the subsequent itemsService.readOne call * Update changeset * Don't require update perms on versions for save * Optimize validateCreateData * update to new validateAccess * Update docs/reference/system/versions.md * Remove migration of delta * Rename to legacy * Add missed changes for Remove migration of delta in 2e2f50f * Update docs/reference/system/versions.md --------- Co-authored-by: Pascal Jufer <[email protected]> Co-authored-by: daedalus <[email protected]> * Update migration dates * api change should be major for versioning * Remove comment paths from activity reference * Added comments reference * Added directus_comments to table of system collections * The linter demands newline * Revert function renaming for patch semver * Use transaction in down migration for comments (#23715) * Remove outdated logic for comments * remove duplicate app access permission * remove unused import/params in gql * remove remaining comment code in activity * remove remaining activity logic in comment * add changeset * reword changeset --------- Co-authored-by: Brainslug <[email protected]> Co-authored-by: Pascal Jufer <[email protected]> Co-authored-by: Brainslug <[email protected]> Co-authored-by: daedalus <[email protected]> Co-authored-by: Daniel Biegler <[email protected]> Co-authored-by: Kevin Lewis <[email protected]> Co-authored-by: Rijk van Zanten <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
What's changed:
Potential Risks / Drawbacks
rowsLimitof50be an issue for tiny instances?Review Notes / Questions