Various improvements for the presentation-links component#21338
Merged
Various improvements for the presentation-links component#21338
Conversation
🦋 Changeset detectedLatest commit: 0afb7cc The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
paescuj
reviewed
Feb 13, 2024
paescuj
reviewed
Feb 13, 2024
paescuj
reviewed
Feb 14, 2024
br41nslug
reviewed
Feb 14, 2024
Co-authored-by: Brainslug <[email protected]>
paescuj
approved these changes
Feb 14, 2024
Contributor
paescuj
left a comment
There was a problem hiding this comment.
Great work, behaving much better now 🚀
This was referenced Feb 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
What's changed:
undefinedfrom presentation links within translations interface #20880Sadly the translation interface issue has thus far eluded my fixing wrath
Potential Risks / Drawbacks
Review Notes / Questions
So after looking into how the presentation-link component works I found out that the only reason we are fetching data at all is because of relations. For the other fields we can just access
valuesof thev-form. For relations however we need to resolve the relation of course so we use the api to get the needed nested-fields.This uncovered to me that we can optimize this component in the following ways:
v-formsprovidedvalues.languages.codeup until you change one field inside the translation-interface because that leads to acreatecall inuse-relation-multiple.tswhich initializes the edited values with our$typeand$indexnotation.